From owner-svn-src-all@freebsd.org Mon Jul 16 16:57:12 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 232A61030D66; Mon, 16 Jul 2018 16:57:12 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from mail.baldwin.cx (bigwig.baldwin.cx [IPv6:2001:470:1f11:75::1]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C3CA079B44; Mon, 16 Jul 2018 16:57:11 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from John-Baldwins-MacBook-Pro-2.local (unknown [IPv6:2601:648:8880:1e30:75c5:bfc5:76a7:2a31]) by mail.baldwin.cx (Postfix) with ESMTPSA id 57C4510B476; Mon, 16 Jul 2018 12:57:10 -0400 (EDT) Subject: Re: svn commit: r336326 - head/sys/dev/ichiic To: Oleksandr Tymoshenko , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201807160134.w6G1YkNR038303@repo.freebsd.org> From: John Baldwin Message-ID: <829a4a12-20d1-e48d-c338-9dd3f67a3969@FreeBSD.org> Date: Mon, 16 Jul 2018 09:57:09 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <201807160134.w6G1YkNR038303@repo.freebsd.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.4.3 (mail.baldwin.cx); Mon, 16 Jul 2018 12:57:10 -0400 (EDT) X-Virus-Scanned: clamav-milter 0.99.2 at mail.baldwin.cx X-Virus-Status: Clean X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 16 Jul 2018 16:57:12 -0000 On 7/15/18 6:34 PM, Oleksandr Tymoshenko wrote: > Author: gonzo > Date: Mon Jul 16 01:34:45 2018 > New Revision: 336326 > URL: https://svnweb.freebsd.org/changeset/base/336326 > > Log: > Remove MODULE_PNP_INFO for ig4(4) driver > > ig4(4) does not support suspend/resume but present on the hardware where > such functionality is critical, like laptops. Remove PNP info to avoid > breaking suspend/resume on the systems where ig4(4) load is not explicitly > requested by the user. > > PR: 229791 > Reported by: Ali Abdallah I wonder if we don't want instead a way to tag a module as "don't autoload" so that you can still have a way to say "show me which unprobed devices have modules available". One option would be to have an rc.conf knob which is a regex that gets used with 'egrep -v' in the rc.d script on the output of devmatch. This has the slight advantage that a user can customize it via rc.conf. (For example, when working on cxgbe(4) on my dev boxes I don't want it to autoload, but in a production environment we might want it to autoload by default.) Another option might be to add some new type of PNP info that is a boolean "autoload" that defaults to true and teach devmatch to honor the boolean. -- John Baldwin