From owner-cvs-src@FreeBSD.ORG  Tue Feb 27 17:41:19 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 4944C16A40B;
	Tue, 27 Feb 2007 17:41:19 +0000 (UTC) (envelope-from sam@errno.com)
Received: from ebb.errno.com (ebb.errno.com [69.12.149.25])
	by mx1.freebsd.org (Postfix) with ESMTP id C2B4913C4B2;
	Tue, 27 Feb 2007 17:41:17 +0000 (UTC) (envelope-from sam@errno.com)
Received: from [10.0.0.248] (trouble.errno.com [10.0.0.248])
	(authenticated bits=0)
	by ebb.errno.com (8.13.6/8.12.6) with ESMTP id l1RHfFA0035336
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO);
	Tue, 27 Feb 2007 09:41:15 -0800 (PST) (envelope-from sam@errno.com)
Message-ID: <45E46D3B.9040203@errno.com>
Date: Tue, 27 Feb 2007 09:41:15 -0800
From: Sam Leffler <sam@errno.com>
User-Agent: Thunderbird 1.5.0.9 (X11/20070208)
MIME-Version: 1.0
To: =?ISO-8859-1?Q?Dag-Erling_Sm=F8rgrav?= <des@des.no>
References: <200702242355.l1ONtlSE066370@repoman.freebsd.org>	<86mz2zwq93.fsf@dwp.des.no>
	<45E461B5.9000404@errno.com> <86fy8rms5j.fsf@dwp.des.no>
In-Reply-To: <86fy8rms5j.fsf@dwp.des.no>
X-Enigmail-Version: 0.94.0.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 8bit
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sbin/ifconfig af_atalk.c af_inet.c af_inet6.c
 af_ipx.c af_link.c ifconfig.c ifconfig.h
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 27 Feb 2007 17:41:19 -0000

Dag-Erling Smørgrav wrote:
> Sam Leffler <sam@errno.com> writes:
>> Dag-Erling Smørgrav wrote:
>>> This commit breaks interface cloning.  Apparently, the global variable
>>> "name" is not initialized before ifclonecreate() is called, so the
>>> SIOCIFCREATE2 ioctl() is called with an empty string instead of the
>>> interface name.
>> Hmm, worked for bridge for me.  Can you provide the specific example?
> 
> Is "ifconfig bridge0 create" specific enough?
> 
> Insert a printf() in the right spot and you'll see name is empty when
> ifclonecreate() is called.

I'd (apparently) tested with a wrong binary.  Unfortunately noone caught
it in the public review either.

	Sam