From owner-freebsd-audit  Sun Jun 24 22:43:27 2001
Delivered-To: freebsd-audit@freebsd.org
Received: from bazooka.unixfreak.org (bazooka.unixfreak.org [63.198.170.138])
	by hub.freebsd.org (Postfix) with ESMTP id 75FBC37B401
	for <audit@FreeBSD.org>; Sun, 24 Jun 2001 22:43:25 -0700 (PDT)
	(envelope-from dima@unixfreak.org)
Received: from hornet.unixfreak.org (hornet [63.198.170.140])
	by bazooka.unixfreak.org (Postfix) with ESMTP
	id 22A633E28; Sun, 24 Jun 2001 22:43:25 -0700 (PDT)
To: Mike Barcroft <mike@q9media.com>
Cc: audit@FreeBSD.org
Subject: Re: src/usr.sbin/spray patch 
In-Reply-To: <200106250544.f5P5iQR91718@coffee.q9media.com>; from mike@q9media.com on "Mon, 25 Jun 2001 01:44:26 -0400 (EDT)"
Date: Sun, 24 Jun 2001 22:43:25 -0700
From: Dima Dorfman <dima@unixfreak.org>
Message-Id: <20010625054325.22A633E28@bazooka.unixfreak.org>
Sender: owner-freebsd-audit@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-audit.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo?subject=subscribe%20freebsd-audit>
List-Unsubscribe: <mailto:majordomo?subject=unsubscribe%20freebsd-audit>
X-Loop: FreeBSD.ORG

Mike Barcroft <mike@q9media.com> writes:
> @@ -186,11 +187,8 @@
>  }
>  
>  
> -void
> -print_xferstats(packets, packetlen, xfertime)
> -	int packets;
> -	int packetlen;
> -	double xfertime;
> +static void
> +print_xferstats(int packets, int packetlen, double xfertime)
>  {
>  	int datalen;
>  	double pps;		/* packets per second */
> @@ -212,7 +210,7 @@
>  
>  
>  static void
> -usage ()
> +usage(void)
>  {

If you're going to ANSIify these, you might as well ANSIify the rest
(i.e., main).  As Warner (imp@) said to me once, "The one thing worse
than old K&R code in the tree is broken K&R code in the tree."

					Dima Dorfman
					dima@unixfreak.org

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-audit" in the body of the message