From owner-cvs-all@FreeBSD.ORG  Tue Jul 14 06:00:29 2009
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 2D91F1065673
	for <cvs-all@FreeBSD.org>; Tue, 14 Jul 2009 06:00:29 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4])
	by mx1.freebsd.org (Postfix) with ESMTP id B88EA8FC1B
	for <cvs-all@FreeBSD.org>; Tue, 14 Jul 2009 06:00:28 +0000 (UTC)
	(envelope-from dougb@FreeBSD.org)
Received: (qmail 2114 invoked by uid 399); 14 Jul 2009 06:00:28 -0000
Received: from localhost (HELO ?192.168.0.100?) (dougb@dougbarton.us@127.0.0.1)
	by localhost with ESMTPAM; 14 Jul 2009 06:00:28 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <4A5C1EFE.5060609@FreeBSD.org>
Date: Mon, 13 Jul 2009 23:00:30 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.22 (Windows/20090605)
MIME-Version: 1.0
To: Wesley Shields <wxs@FreeBSD.org>
References: <200907131622.n6DGMuOa014201@repoman.freebsd.org>
In-Reply-To: <200907131622.n6DGMuOa014201@repoman.freebsd.org>
X-Enigmail-Version: 0.95.7
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, "Rashid N. Achilov" <citycat4@ngs.ru>,
	cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/net-mgmt/flowd Makefile
 ports/net-mgmt/flowd/files flowd.in
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: **OBSOLETE** CVS commit messages for the entire tree
	<cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 14 Jul 2009 06:00:29 -0000

Wesley Shields wrote:
> wxs         2009-07-13 16:22:56 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     net-mgmt/flowd       Makefile 
>   Added files:
>     net-mgmt/flowd/files flowd.in 
>   Log:
>   - Install RC script.
>   
>   PR:             ports/135949  http://www.FreeBSD.org/cgi/query-pr.cgi?pr=135949
>   Submitted by:   Rashid N. Achilov <citycat4@ngs.ru>
>   Approved by:    maintainer timeout
>   
>   Revision  Changes    Path
>   1.14      +2 -0      ports/net-mgmt/flowd/Makefile
>   1.1       +30 -0     ports/net-mgmt/flowd/files/flowd.in (new)
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/Makefile.diff?&r1=1.13&r2=1.14&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/net-mgmt/flowd/files/flowd.in
> 
Overall this looks quite good, thanks! The only thing I would change
is to eliminate the empty _flags assignment, and include that in the
example comments at the top. You might also want to s/ipcad/flowd/. :)


hth,

Doug