Date: Wed, 20 Apr 2022 14:23:25 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 263159] [NEW PORT] games/solver Math quiz game Message-ID: <bug-263159-7788-cFlpkpIkxb@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-263159-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-263159-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263159 --- Comment #2 from Robert Clausecker <fuz@fuz.su> --- Hi, I suppose this is your project. Please consider fixing the git repository so it actually contains the source files, not an archive of them. Then tag a release and use USE_GITHUB to specify the master site. The current approach is not forbidden, but it's certainly very unconvention= al. As for LIB_DEPENDS, why do you use ?=3D ? Is there any particular reason? The SETUID logic is not going to work the way you envision it; setuid bits = must be specified in the plist. Instead use the pattern found in sysutils/cdrto= ols for this purpose. Why do you need Setuid functionality anyway? In any way, ports that setuid have to be treated with care as they are a potential security risk. If it is for score files, put the binary into the games group and setgid it= .=20 Install blank scores file using the @sample mechanism into the appropriate location (see games/nbsdgames for an example) such that they are writable to the games user. If it is for accessing the screen, I'm not sure if setuid is appropriate.=20 Check if one of the groups video, operator, or wheel do the trick, too. I forgot how exactly this works. Also consider porting your code to a library that works on X11 such as SDL2. Make sure to consistently use ${...} instead of $(...) in the port Makefile. Your distribution file seems to have no top level directory. Use NO_WRKSUB= DIR to have the ports system create one for you. Do not set WRKSRC in this case and change your do-build and do-install targets to take source files from WRKSRC, not WRKDIR.c --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-263159-7788-cFlpkpIkxb>