From owner-svn-src-stable-9@FreeBSD.ORG Fri Apr 26 18:00:33 2013 Return-Path: Delivered-To: svn-src-stable-9@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id D704BFB1; Fri, 26 Apr 2013 18:00:33 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-ee0-f51.google.com (mail-ee0-f51.google.com [74.125.83.51]) by mx1.freebsd.org (Postfix) with ESMTP id E8DB9162B; Fri, 26 Apr 2013 18:00:32 +0000 (UTC) Received: by mail-ee0-f51.google.com with SMTP id c1so871577eek.10 for ; Fri, 26 Apr 2013 11:00:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:sender:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=QIET37CWScrR/3482nqS4ZugrBZn/Eg9S0gvRVWOip0=; b=tphN8NFCYcgRPIQo/tLiNAeQJNkH9Y1bBFe+7w4/gsEWk/YI7pddPKS48SBeBIajG8 jeZemrINm7LGcx++P+LOtFuL/TQlsqFg22P02wtTLu05YIce1E+8Ywm9qBbkI3uDXY1X kD5uwXfwMKycrFhX3L2hFsi8+b00FzeMKN2AU9ifAH7Ru+g1N+zgfyPJHoGgpUWXU0Wk gvZ2Qx0uM3dYTtClg+s9HBWD1FxiPGMjaQKzjO8TPvDW3G4S7MIoGxLufeXlpblxfb2m QV90sGfXn5LOGuNbP0C15bU9i5kZyLQBY9s84KbpY+mCvwvBv6grNmycGlYTUZSRKOYT ASjw== X-Received: by 10.14.3.9 with SMTP id 9mr13705083eeg.33.1366999231520; Fri, 26 Apr 2013 11:00:31 -0700 (PDT) Received: from mavbook.mavhome.dp.ua (mavhome.mavhome.dp.ua. [213.227.240.37]) by mx.google.com with ESMTPSA id i53sm17250107eeu.5.2013.04.26.11.00.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Fri, 26 Apr 2013 11:00:30 -0700 (PDT) Sender: Alexander Motin Message-ID: <517AC0BB.4040207@FreeBSD.org> Date: Fri, 26 Apr 2013 21:00:27 +0300 From: Alexander Motin User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:17.0) Gecko/20130413 Thunderbird/17.0.5 MIME-Version: 1.0 To: Peter Wemm Subject: Re: svn commit: r249611 - in stable/9/sys/cam: ata scsi References: <201304180944.r3I9i05t093967@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: svn-src-stable@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, svn-src-stable-9@freebsd.org X-BeenThere: svn-src-stable-9@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for only the 9-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Apr 2013 18:00:33 -0000 On 26.04.2013 19:47, Peter Wemm wrote: > On Thu, Apr 18, 2013 at 2:44 AM, Alexander Motin wrote: >> Author: mav >> Date: Thu Apr 18 09:44:00 2013 >> New Revision: 249611 >> URL: http://svnweb.freebsd.org/changeset/base/249611 >> >> Log: >> MFC r248872, r249048: >> Make pre-shutdown flush and spindown routines to not use xpt_polled_action(), >> but execute the commands in regular way. There is no any reason to cook CPU >> while the system is still fully operational. After this change polling in >> CAM is used only for kernel dumping. > > FYI, this causes some drivers to deadlock when you attempt to cleanly > reboot the machine. eg: mpt based systems. Thank you for the report, but I've seen your first email 23.04 and replied you with proposed solution the same day. > Adding new assumptions about interrupt-driven hooks continuing to work > after the post-sync shutdown hooks don't seem like a -stable > candidate. That is not "after the post-sync", but the post-sync itself. Is it written somewhere that it should not work? Because several GEOM modules are also doing some disk writes at post-sync stage and they expect to be handled in normal way. > This breaks a number of machines in the freebsd.org cluster. I have > to back out both of these changes to get them to reboot. I've made a search though the base system and found only two drivers affected by this change: mpt and hptmv. I've patched both at head r249849 and going to merge fix to stable/9 tomorrow unless objected. Have you tried that patch instead of reverting? -- Alexander Motin