From owner-freebsd-ports@FreeBSD.ORG Sat Mar 28 03:25:59 2009 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 3582F106564A; Sat, 28 Mar 2009 03:25:59 +0000 (UTC) (envelope-from lstewart@room52.net) Received: from outbound.icp-qv1-irony-out3.iinet.net.au (outbound.icp-qv1-irony-out3.iinet.net.au [203.59.1.148]) by mx1.freebsd.org (Postfix) with ESMTP id 7447E8FC14; Sat, 28 Mar 2009 03:25:57 +0000 (UTC) (envelope-from lstewart@room52.net) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAGIuzUl8qF1T/2dsb2JhbADQCIN3Bg X-IronPort-AV: E=Sophos;i="4.38,436,1233500400"; d="scan'208";a="409144810" Received: from unknown (HELO lawrence1.loshell.room52.net) ([124.168.93.83]) by outbound.icp-qv1-irony-out3.iinet.net.au with ESMTP; 28 Mar 2009 11:55:54 +0900 Message-ID: <49CD91B9.1080902@room52.net> Date: Sat, 28 Mar 2009 13:55:53 +1100 From: Lawrence Stewart User-Agent: Thunderbird 2.0.0.21 (X11/20090326) MIME-Version: 1.0 To: Rui Paulo References: <49CD67C2.7010109@room52.net> <766A50DC-D190-4292-A117-2EC5E40715AC@FreeBSD.org> In-Reply-To: <766A50DC-D190-4292-A117-2EC5E40715AC@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: alexey@renatasystems.org, freebsd-ports@freebsd.org Subject: Re: [PATCH] trafshow port broken X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 28 Mar 2009 03:25:59 -0000 Rui Paulo wrote: > > On 27 Mar 2009, at 23:56, Lawrence Stewart wrote: > >> Hi Alexey, >> >> You're listed as the maintainer for the FreeBSD net/trafshow port. The >> port doesn't compile on 8.0-CURRENT (r190457) amd64 at the moment. The >> recent import of the new pcap into FreeBSD 8 means pcap.h no longer >> includes the system's net/bpf.h, which has a required #define ioctl >> (BIOCIMMEDIATE). Placing the attached patch in the port's files >> directory fixes the issue for me. The patch should only be required >> for ${OSVERSION} >= 800074. >> >> Rui, is patching the port the correct fix for this issue? > > I think so. Hard to tell without looking at the program itself. Ok cool. Just wanted to check that this wasn't *unexpected* fallout from the recent pcap import and that a conscious decision has been made to not include the system's bpf.h in pcap.h. Probably worth keeping an eye out on the ports build cluster for any other ports that look like they're failing to build because of bpf.h issues. Cheers, Lawrence