From owner-svn-ports-all@freebsd.org Thu Apr 2 16:56:10 2020 Return-Path: Delivered-To: svn-ports-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3ECCD2AC65E; Thu, 2 Apr 2020 16:56:10 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: from mail-ua1-f45.google.com (mail-ua1-f45.google.com [209.85.222.45]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48tTjP0Fqlz45yS; Thu, 2 Apr 2020 16:56:08 +0000 (UTC) (envelope-from fernando.apesteguia@gmail.com) Received: by mail-ua1-f45.google.com with SMTP id 9so1464293uav.12; Thu, 02 Apr 2020 09:56:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=AgVx5gZYe9jcm/CH4EV4azGGSr9dQ396M9BU07c4raE=; b=l1xmmWs/Wl7YdFEorGyVHC6GN4kdyT1pNSKO0eKRoA+5mWGaAY/AHx/J9T1Sfyxd/1 JhBjX5oGnb/7nTpM46ml6QjDUWhjT/U4zdsOx58RoDKKpOUCnKyXZN32LL8sI7ltJlPK S2xnXY9Y9qBuBNv3JHrbRwTPVlC/WeNmu+rgir/8uYJunTlV58s86TifJr6bDvP7U1m1 e9+Chm6fPdVRUYJKB6M3sq3fao9DmrO2452UTr9rOAewm6Ra6taERbcxqZru6zQUy4sC DEGl3DACx9E2uUBLNXywOguWBYRld/FrY8emz45Cftseb2ZfCCpfkkpkNzMqFFIasTc+ V9DA== X-Gm-Message-State: AGi0PubJPGwyS4lnPvcXwHBG5sSP+Wjv+J0HGTtOBDwdVH74fijyTyeR typ2H8Iiud59X/8BxuNiAeJ3qeFiLLA= X-Google-Smtp-Source: APiQypJajNPFNfze7hT9vcvmFRyymkm13wvq8zaXNVmKGDcuwGug8OTEJloTuxMtHSJVcgYxFZr4gw== X-Received: by 2002:a9f:36c5:: with SMTP id p63mr3304823uap.19.1585846563457; Thu, 02 Apr 2020 09:56:03 -0700 (PDT) Received: from mail-ua1-f50.google.com (mail-ua1-f50.google.com. [209.85.222.50]) by smtp.gmail.com with ESMTPSA id k14sm1393054vsb.14.2020.04.02.09.56.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2020 09:56:03 -0700 (PDT) Received: by mail-ua1-f50.google.com with SMTP id g10so1484300uae.5; Thu, 02 Apr 2020 09:56:03 -0700 (PDT) X-Received: by 2002:a9f:2281:: with SMTP id 1mr3430418uan.12.1585846562801; Thu, 02 Apr 2020 09:56:02 -0700 (PDT) MIME-Version: 1.0 References: <202004021151.032BpOMI028447@repo.freebsd.org> In-Reply-To: From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= Date: Thu, 2 Apr 2020 19:56:16 +0200 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r530275 - in head/sysutils/checkrestart: . files To: Mateusz Piotrowski <0mp@freebsd.org> Cc: "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, tom@hur.st Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 48tTjP0Fqlz45yS X-Spamd-Bar: ----- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-6.00 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Apr 2020 16:56:10 -0000 On Thu, Apr 2, 2020 at 2:00 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > Hi, > > On 4/2/20 1:51 PM, Fernando Apestegu=C3=ADa wrote: > > Author: fernape > > Date: Thu Apr 2 11:51:24 2020 > > New Revision: 530275 > > URL: https://svnweb.freebsd.org/changeset/ports/530275 > > > > Log: > > sysutils/checkrestart: Update to 0.5.0 > ... > > Added: head/sysutils/checkrestart/files/checkrestart.in > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/sysutils/checkrestart/files/checkrestart.in Thu Apr 2 11:51:= 24 2020 (r530275) > > @@ -0,0 +1,70 @@ > > +#!/bin/sh > > +# $FreeBSD$ > > + > > +if [ -r /etc/defaults/periodic.conf ]; then > > + . /etc/defaults/periodic.conf > > + source_periodic_confs > > +fi > > + > > +: "${daily_checkrestart_enable:=3DNO}" > > +: "${daily_checkrestart_weekdays:=3D1234567}" # Days of the week to ru= n, Monday=3D1 > > +: "${daily_checkrestart_users:=3D}" # User names or IDs to c= heck > > +: "${daily_checkrestart_jails:=3D}" # Jail names or IDs to c= heck > > +: "${daily_checkrestart_procs:=3D}" # Process names or IDs t= o check > > + > > +checkrestartcmd=3D/usr/local/bin/checkrestart > > This should probably utilize %%PREFIX%%. > > > + > > +case "${daily_checkrestart_enable}" in > > + [Yy][Ee][Ss]) > Please use checkyesno from rc.subr(8) instead. Hi Mateusz, Thanks for the point. Would you have a look at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245283? The maintainer doesn't see appropriate this last suggestion. Feel free to jump in. Cheers. > > > Cheers, > > Mateusz Piotrowski >