Date: Thu, 2 Apr 2020 19:56:16 +0200 From: =?UTF-8?Q?Fernando_Apestegu=C3=ADa?= <fernape@freebsd.org> To: Mateusz Piotrowski <0mp@freebsd.org> Cc: "ports-committers@FreeBSD.org" <ports-committers@freebsd.org>, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, tom@hur.st Subject: Re: svn commit: r530275 - in head/sysutils/checkrestart: . files Message-ID: <CAGwOe2ZaVD-i1Nto%2BCSBL%2BxxzrmNptxMhNijSCrO5LVYgz5Grg@mail.gmail.com> In-Reply-To: <b5e76d0b-b3cf-0c02-10fa-db607eab1df8@FreeBSD.org> References: <202004021151.032BpOMI028447@repo.freebsd.org> <b5e76d0b-b3cf-0c02-10fa-db607eab1df8@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Apr 2, 2020 at 2:00 PM Mateusz Piotrowski <0mp@freebsd.org> wrote: > > Hi, > > On 4/2/20 1:51 PM, Fernando Apestegu=C3=ADa wrote: > > Author: fernape > > Date: Thu Apr 2 11:51:24 2020 > > New Revision: 530275 > > URL: https://svnweb.freebsd.org/changeset/ports/530275 > > > > Log: > > sysutils/checkrestart: Update to 0.5.0 > ... > > Added: head/sysutils/checkrestart/files/checkrestart.in > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- /dev/null 00:00:00 1970 (empty, because file is newly added) > > +++ head/sysutils/checkrestart/files/checkrestart.in Thu Apr 2 11:51:= 24 2020 (r530275) > > @@ -0,0 +1,70 @@ > > +#!/bin/sh > > +# $FreeBSD$ > > + > > +if [ -r /etc/defaults/periodic.conf ]; then > > + . /etc/defaults/periodic.conf > > + source_periodic_confs > > +fi > > + > > +: "${daily_checkrestart_enable:=3DNO}" > > +: "${daily_checkrestart_weekdays:=3D1234567}" # Days of the week to ru= n, Monday=3D1 > > +: "${daily_checkrestart_users:=3D}" # User names or IDs to c= heck > > +: "${daily_checkrestart_jails:=3D}" # Jail names or IDs to c= heck > > +: "${daily_checkrestart_procs:=3D}" # Process names or IDs t= o check > > + > > +checkrestartcmd=3D/usr/local/bin/checkrestart > > This should probably utilize %%PREFIX%%. > > > + > > +case "${daily_checkrestart_enable}" in > > + [Yy][Ee][Ss]) > Please use checkyesno from rc.subr(8) instead. Hi Mateusz, Thanks for the point. Would you have a look at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D245283? The maintainer doesn't see appropriate this last suggestion. Feel free to jump in. Cheers. > > > Cheers, > > Mateusz Piotrowski >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGwOe2ZaVD-i1Nto%2BCSBL%2BxxzrmNptxMhNijSCrO5LVYgz5Grg>