From owner-freebsd-hackers@freebsd.org Sun Mar 24 23:47:33 2019 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 4D30F15489C1; Sun, 24 Mar 2019 23:47:33 +0000 (UTC) (envelope-from rebecca@bluestop.org) Received: from muon.bluestop.org (muon.bluestop.org [65.103.231.193]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C90586D819; Sun, 24 Mar 2019 23:47:32 +0000 (UTC) (envelope-from rebecca@bluestop.org) Received: from muon.bluestop.org (localhost [127.0.0.1]) by muon.bluestop.org (Postfix) with ESMTP id 8AACFC0A16; Sun, 24 Mar 2019 17:48:28 -0600 (MDT) Received: from muon.bluestop.org ([127.0.0.1]) by muon.bluestop.org (muon.bluestop.org [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id 0j6xUlv5kZu2; Sun, 24 Mar 2019 17:48:28 -0600 (MDT) Received: from photon.int.bluestop.org (unknown [65.103.231.197]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by muon.bluestop.org (Postfix) with ESMTPSA; Sun, 24 Mar 2019 17:48:28 -0600 (MDT) Subject: Re: Adding a new efi-update-loader script: need help understanding Makefile.inc1 for "make installworld" To: Konstantin Belousov Cc: FreeBSD Hackers , arch@freebsd.org References: <642fed43-0535-9ae3-6f01-a943650cd511@bluestop.org> <20190324090103.GO1923@kib.kiev.ua> From: Rebecca Cran Message-ID: Date: Sun, 24 Mar 2019 17:47:23 -0600 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <20190324090103.GO1923@kib.kiev.ua> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US X-Rspamd-Queue-Id: C90586D819 X-Spamd-Bar: ------ X-Spamd-Result: default: False [-6.99 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.99)[-0.991,0] X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 Mar 2019 23:47:33 -0000 On 3/24/19 3:01 AM, Konstantin Belousov wrote: > > Can we take use of the opportunity and finally stop installing loader > at installworld target at all, please ? > > Add e.g. installloader target which would do whatever needed to loader. Others have suggested adding a new step as well. I'm not sure we need it as a make target, but perhaps a generic script such as "update-loader" that will call "efi-update-loader" if on a UEFI system, or "boot0cfg" etc. on an MBR system (i.e. it knows how to install boot/loader code for all systems we support)? Also, about the naming: would you prefer 'install' or 'update' in the script name? When you say "stop installing loader", do you mean stop installing /boot/loader* entirely, or leave installworld installing those, but have updating the ESP as the extra step? -- Rebecca Cran