From owner-freebsd-multimedia@FreeBSD.ORG Mon Apr 3 16:17:22 2006 Return-Path: X-Original-To: freebsd-multimedia@FreeBSD.org Delivered-To: freebsd-multimedia@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3142316A427 for ; Mon, 3 Apr 2006 16:17:22 +0000 (UTC) (envelope-from ariff@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0501743D77; Mon, 3 Apr 2006 16:17:19 +0000 (GMT) (envelope-from ariff@FreeBSD.org) Received: from misaki (root@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.4/8.13.4) with SMTP id k33GHGxY032225; Mon, 3 Apr 2006 16:17:17 GMT (envelope-from ariff@FreeBSD.org) Date: Tue, 4 Apr 2006 00:17:01 +0800 From: Ariff Abdullah To: freebsd@orchid.homeunix.org Message-Id: <20060404001701.19e70cf9.ariff@FreeBSD.org> In-Reply-To: <443101D6.1050008@orchid.homeunix.org> References: <4430FCCC.2070806@orchid.homeunix.org> <443101D6.1050008@orchid.homeunix.org> Organization: FreeBSD X-Mailer: /usr/local/lib/ruby/1.8/net/smtp.rb Mime-Version: 1.0 Content-Type: multipart/signed; protocol="application/pgp-signature"; micalg="PGP-SHA1"; boundary="Signature=_Tue__4_Apr_2006_00_17_01_+0800_RHj+x2MClcx/=dsZ" Cc: freebsd-multimedia@FreeBSD.org Subject: Re: Does Ariff's sound patch still work with 6.0-RELEASE? X-BeenThere: freebsd-multimedia@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Multimedia discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Apr 2006 16:17:22 -0000 --Signature=_Tue__4_Apr_2006_00_17_01_+0800_RHj+x2MClcx/=dsZ Content-Type: text/plain; charset=US-ASCII Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, 03 Apr 2006 13:07:02 +0200 Karol Kwiatkowski wrote: > Ehh... My humble apology to Ariff for writing his name with small > letters. Sorry! >=20 Eh.. it's ok, you don't have to be sorry for that :) >=20 > On 04/03/06 12:45, Karol Kwiatkowski wrote: > > Hi all, > >=20 > > Did anyone successfully compile kernel on 6.0-RELEASE with ariff's > > sound patch recently? File in question: > > snd_RELENG_6_0_20060227_098.diff from > > http://people.freebsd.org/~ariff/ > >=20 > > I'm trying to help another user (remotely) to get his VIA 8233 > > work with Skype on 6.0-RELEASE. However, he is unable to compile > > patched kernel (more information below). We tried few times, last > > step was: remove /usr/src/*, cvsup to RELENG_6_0, patch, make > > buildkernel (custom). > >=20 > > I'm asking here (I don't have 6.0-RELEASE myself) because I tried > > to look at source files given by error message[1] and at a diff > > itself and noticed: > >=20 > > - diff for RELENG_6_0 updates feeder_rate.c v 1.11 to 1.17 > > - adds into feeder_rate.c: +#define RATE_FACTOR_MAX PCM_S24_MAX > > - I can't find any definition of PCM_S24_MAX in feeder_rate.c nor > > sound.h(v 1.63) > > - in fact feeder_rate.c v 1.17 from cvs/web[2] doesn't include the > > line "#define RATE_FACTOR_MAX PCM_S24_MAX" > >=20 > > Am I missing something (yes, I'm lost at this stage) or is > > snd_RELENG_6_0_20060227_098.diff broken? > >=20 > >=20 This is my fault (broken diff). I'm having hard time maintaining diffs for various branches, and about to abandon 6.0-RELEASE/5.4-RELEASE sooner or later. I've just uploaded rev. 099 . It contains lots of fixes. Give it a try. If you having difficulties using the diff, you can use binary compiled kernel modules: http://people.freebsd.org/~ariff/test/sndkld_r6.tar.gz Extract, move everything to /boot/kernel/ (take a backup first!), and do kldxref /boot/kernel . > > Thank you in advance, > >=20 > > Karol > >=20 > > [1] > > [...] > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:342: error: (near initialization for `convtbl[26].bps') > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:342: error: initializer element is not constant > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:342: error: (near initialization for `convtbl[26]') > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:343: error: initializer element is not constant > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:343: error: (near initialization for `convtbl[27].bps') > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:343: error: initializer element is not constant > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:343: error: (near initialization for `convtbl[27]') > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:344: error: initializer element is not constant > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:344: error: (near initialization for `convtbl[28]') > > /usr/src/sys/modules/sound/sound/../../../dev/sound/pcm/feeder_ra > > te.c:354: error: `PCM_S24_MAX' undeclared (first use in this > > function) *** Error code 1 > >=20 > > Stop in /usr/src/sys/modules/sound/sound. > > *** Error code 1 > >=20 > >=20 > > [2] > > http://www.freebsd.org/cgi/cvsweb.cgi/~checkout~/src/sys/dev/sound/pcm/= feeder_rate.c?rev=3D1.17&content-type=3Dtext/plain > >=20 >=20 -- Ariff Abdullah FreeBSD --Signature=_Tue__4_Apr_2006_00_17_01_+0800_RHj+x2MClcx/=dsZ Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.2.2 (FreeBSD) iD8DBQFEMUqAlr+deMUwTNoRAoKlAJ9czQxK8tiHf2LwFqNd45LTq9paNQCgt7BT 5yHUIOJlCv/YHkNRr7HH5sI= =IaHC -----END PGP SIGNATURE----- --Signature=_Tue__4_Apr_2006_00_17_01_+0800_RHj+x2MClcx/=dsZ--