From owner-freebsd-net@freebsd.org Thu Dec 24 08:23:47 2015 Return-Path: Delivered-To: freebsd-net@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id BC3DDA51285 for ; Thu, 24 Dec 2015 08:23:47 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: from mail-lf0-x236.google.com (mail-lf0-x236.google.com [IPv6:2a00:1450:4010:c07::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 509EF19FA for ; Thu, 24 Dec 2015 08:23:47 +0000 (UTC) (envelope-from woodsb02@gmail.com) Received: by mail-lf0-x236.google.com with SMTP id z124so154627822lfa.3 for ; Thu, 24 Dec 2015 00:23:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; bh=eA4V1xSJdUw7Sgr9Z6OjILoJtiLo8fMSCEpuanF/Q2w=; b=Xvlt23e6uNPgXCTNKbegy+PK+Vgsz8zcE33QAzttPuIk+2J26/G3TAFvphxnthIfb/ bYdxeL2/OMXWWDp0xURqw61AvqvadZe2LKV+wkqrDlUZAIEa9vrqfGPMMy7kejVrUiNq XMBT5s4FYiBBsANT4Ec831FlCsXiQhtzDIZRfBCJklk37XbMqS0H3X57WzfZsfl1qwqb 71qE8EeToFVcZxFursoGhua2SSwSpracyjC9VFOVC/u+TAC9aa9OpjszPIBPllGvZcCX f/7I04uJ7OQJYLPKFsXkbTmkoFjQS5ZVy095009o40kay7H0l60KKmq1WJx9QVeeOtkT 6XDQ== MIME-Version: 1.0 X-Received: by 10.25.17.32 with SMTP id g32mr12554163lfi.38.1450945424842; Thu, 24 Dec 2015 00:23:44 -0800 (PST) Received: by 10.25.141.129 with HTTP; Thu, 24 Dec 2015 00:23:44 -0800 (PST) In-Reply-To: <20151224063933.GB10898@yongmincho-All-Series> References: <20151224063933.GB10898@yongmincho-All-Series> Date: Thu, 24 Dec 2015 09:23:44 +0100 Message-ID: Subject: Re: tcp keep-alive message sent without timestamp option From: Ben Woods To: Yongmin Cho Cc: "freebsd-net@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Dec 2015 08:23:47 -0000 On Thursday, 24 December 2015, Yongmin Cho wrote: > Hi, all. > > I have checked tcp keep-alive in freebsd head. > According to RFC7323, tcp timestamp option must be sent with > keep-alive packet after timestamp option has been negotiated. > So I have tested this on linux-3.13.0. > tcp keep-alive message is sent with timestamp option on linux-3.13.0. > But on freebsd head, tcp keep-alive packet is sent without timestamp option > after negotiated. So I made patch file based on freebsd head. > Please check this patch file. any feedback will be welcome. > > Thank you in advance for your answers! > > According in RFC7323: > Once TSopt has been successfully negotiated, that is both > and contain TSopt, the TSopt MUST be sent in every non- > segment for the duration of the connection, and SHOULD be sent in > an segment (see Section 5.2 for details). The TCP SHOULD > remember this state by setting a flag, referred to as Snd.TS.OK, > to one. If a non- segment is received without a TSopt, a TCP > SHOULD > silently drop the segment. A TCP MUST NOT abort a TCP connection > because any segment lacks an expected TSopt. > I recommend opening a bug report at https://bugs.freebsd.org/bugzilla/ with this explanation and attaching the patch, so that this issue can be discussed and doesn't get forgotten. Please also reply to this thread with the bug number once it is known. Regards, Ben -- -- From: Benjamin Woods woodsb02@gmail.com