From owner-freebsd-stable  Thu Nov  1 10:40:54 2001
Delivered-To: freebsd-stable@freebsd.org
Received: from iguana.aciri.org (iguana.aciri.org [192.150.187.36])
	by hub.freebsd.org (Postfix) with ESMTP id 90F4437B401
	for <stable@freebsd.org>; Thu,  1 Nov 2001 10:40:51 -0800 (PST)
Received: (from rizzo@localhost)
	by iguana.aciri.org (8.11.3/8.11.1) id fA1IbJw33629;
	Thu, 1 Nov 2001 10:37:19 -0800 (PST)
	(envelope-from rizzo)
Date: Thu, 1 Nov 2001 10:37:19 -0800
From: Luigi Rizzo <rizzo@aciri.org>
To: John Merryweather Cooper <john_m_cooper@yahoo.com>
Cc: stable@freebsd.org
Subject: Re: problem building smbfs module, any hint ?
Message-ID: <20011101103719.N23297@iguana.aciri.org>
References: <20011101101325.L23297@iguana.aciri.org> <20011101102250.E63936@johncoop.MSHOME> <20011101102553.M23297@iguana.aciri.org> <20011101103344.M63936@johncoop.MSHOME>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20011101103344.M63936@johncoop.MSHOME>
User-Agent: Mutt/1.3.23i
Sender: owner-freebsd-stable@FreeBSD.ORG
Precedence: bulk
List-ID: <freebsd-stable.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20freebsd-stable>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20freebsd-stable>
X-Loop: FreeBSD.ORG

> I believe you are wrong, at least as to -STABLE.  Anyway, that's where 
> that header comes from, you don't have it and SMBFS won't build without 
> it.

ok, thanks for the hint.
I still think there is a bug in the dependency then, because at
least from what i have seen when KLDfying other modules,
you make sure that your kernel contains all is needed
for later loading the module.

I.e. code depending on option FOO is changed from

    #ifdef FOO
    #include <sys/foo/bar.h>
    #endif
    ....
    #ifdef FOO
	    <section of code>
    #endif

to
    #include <sys/foo/bar.h>
    ....
	if (foo_is_loaded) {
	    <section of code>
	}
    ...

Do you know which files depend on the option you mentioned ?

	cheers
	luigi

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-stable" in the body of the message