Date: Wed, 20 Apr 2022 15:14:43 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 263159] [NEW PORT] games/solver Math quiz game Message-ID: <bug-263159-7788-gdBDX6IsYK@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-263159-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-263159-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263159 --- Comment #4 from modex@danwin1210.de --- Hi, I suppose this is your project. - Correct. My info should be in the Makefile, thought please let me know if= it is incorrect. Please consider fixing the git repository so it actually contains the source files, not an archive of them. Then tag a release and use USE_GITHUB to specify the master site. - Ok, understood. As for LIB_DEPENDS, why do you use ?=3D ? Is there any particular reason? - No particular reason. Do you suggest I change this or does this matter? The SETUID logic is not going to work the way you envision it; setuid bits = must be specified in the plist. Instead use the pattern found in sysutils/cdrto= ols for this purpose. - I am using it in the same manner as another port: https://cgit.freebsd.org/ports/tree/graphics/acidwarp/Makefile The port also uses svgalib. I see the SETUID in cdrtools and can make that change: https://cgit.freebsd.org/ports/tree/sysutils/cdrtools/Makefile Why do you need Setuid functionality anyway? In any way, ports that setuid have to be treated with care as they are a potential security risk. - It is the nature of svgalib. For a non-root user to use an svgalib application this must be set. Make sure to consistently use ${...} instead of $(...) in the port Makefile. - Understood. I can make this change. I see where i have (CC) and such. Your distribution file seems to have no top level directory. Use NO_WRKSUB= DIR to have the ports system create one for you. Do not set WRKSRC in this case and change your do-build and do-install targets to take source files from WRKSRC, not WRKDIR.c - I will give this a shot as well and re-upload the shar with the changes. Thank you. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-263159-7788-gdBDX6IsYK>