From owner-svn-ports-head@FreeBSD.ORG Sat Oct 12 19:09:41 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTP id 40C7E7E3; Sat, 12 Oct 2013 19:09:41 +0000 (UTC) (envelope-from crees@bayofrum.net) Received: from mk-outboundfilter-5.mail.uk.tiscali.com (mk-outboundfilter-5.mail.uk.tiscali.com [212.74.114.1]) by mx1.freebsd.org (Postfix) with ESMTP id 1A8872C68; Sat, 12 Oct 2013 19:09:39 +0000 (UTC) X-Trace: 24797219/mk-outboundfilter-5.mail.uk.tiscali.com/PIPEX/$ON_NET_AUTH_ACCEPTED/Talk_Talk_Customer/2.102.106.185/None/crees@bayofrum.net X-SBRS: None X-RemoteIP: 2.102.106.185 X-IP-MAIL-FROM: crees@bayofrum.net X-SMTP-AUTH: bayofrum@uwclub.net X-MUA: X-IP-BHB: Once X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AuoIAB+eWVICZmq5/2dsb2JhbABZFoJxOA4Dg2q+OgqBDhd0giUBAQUjMyMMBAsOAwQBAQMCHwcCAjkWCAYBEogKCKstkhCBKY4pBwYogjyBOQOZNIR1i16BZoE/Ow X-IPAS-Result: AuoIAB+eWVICZmq5/2dsb2JhbABZFoJxOA4Dg2q+OgqBDhd0giUBAQUjMyMMBAsOAwQBAQMCHwcCAjkWCAYBEogKCKstkhCBKY4pBwYogjyBOQOZNIR1i16BZoE/Ow X-IronPort-AV: E=Sophos;i="4.93,481,1378854000"; d="scan'208";a="24797219" X-IP-Direction: OUT Received: from host-2-102-106-185.as13285.net (HELO pegasus.bayofrum.net) ([2.102.106.185]) by smtp.pipex.tiscali.co.uk with ESMTP; 12 Oct 2013 20:09:15 +0100 Received: from android-58098a8d81f27ad6.bayofrum.net (android-58098a8d81f27ad6.bayofrum.net [192.168.1.92]) by pegasus.bayofrum.net (Postfix) with ESMTPA id E9DAA41528; Sat, 12 Oct 2013 20:09:09 +0100 (BST) Date: Sat, 12 Oct 2013 20:09:12 +0100 From: Chris Rees To: Jason Helfman , pgsql@freebsd.org, Sunpoet Po-Chuan Hsieh Message-ID: <7325bc9d-a492-4b96-b9dc-3a3f8ecbcf3b.maildroid@localhost> In-Reply-To: References: <201310100009.r9A09Zah023159@svn.freebsd.org> Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper... MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-bayofrum-MailScanner-Information: Please contact the ISP for more information X-bayofrum-MailScanner-ID: E9DAA41528.AB095 X-bayofrum-MailScanner: Found to be clean X-bayofrum-MailScanner-From: crees@bayofrum.net X-Spam-Status: No Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 12 Oct 2013 19:09:41 -0000 Looks fine to me, if Jason approves. Thanks also for the Python changes. Chris -----Original Message----- From: Sunpoet Po-Chuan Hsieh To: Jason Helfman , pgsql@freebsd.org Cc: ports-committers , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Sent: Sat, 12 Oct 2013 19:55 Subject: Re: svn commit: r329946 - in head/databases: postgresql84-client postgresql84-contrib postgresql84-docs postgresql84-server postgresql90-client postgresql90-contrib postgresql90-docs postgresql90-plper... Hi Jason and pgsql@ team, May I suggest to remove DISTV as it's only used in PKGNAMESUFFIX and portlint complains [1]. I have prepared a patch [2] which contains 2 changes: 1) PKGNAMESUFFIX?=${DISTVERSION:R:S/.//}${COMPONENT} 2) Convert to new LIB_DEPENDS format for postgresql*-contrib ports I have also checked PKGNAME is unchanged after applying this patch. Please review it. Thanks. [1] FATAL: Makefile: extra item "DISTV" placed in the PORTNAME section. [2] http://people.freebsd.org/~sunpoet/postgresql-pkgname.patch Regards, sunpoet -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean.