From nobody Fri Apr 24 15:15:52 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4g2GkP3x34z6bRW4 for ; Fri, 24 Apr 2026 15:15:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R13" (not verified)) by mx1.freebsd.org (Postfix) with ESMTPS id 4g2GkP3FTnz3Bvy for ; Fri, 24 Apr 2026 15:15:57 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777043757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+h4HlcJTbOMYbGuIpTcNMNA8U5/XAoEZtOP6m07p9q8=; b=UfJlqIbS3ujxXwml3BwBZz1Lck/nxxbuoMZ2U3Y6F7qTUCbrvSSlRet4mDTWmyBIB37Fo2 2OgAAVRjW0WzxAsi1OUckEvHBOmIuBooYsh4t85BUYg+wiSLXSI5/Ca4dc9LMh5ml7OLac fYrWDTe4X4zrxFkfDNBuy+Nb9VZYsh6lyY5O803WdY+5hDpi4igcRQWFQMSMECX7sqZZuC 6OGxl8uSSmrD/hEfCTqjiCujP/p0180NZj3WVFlnUCf3/eTNHelhY7QoffN8o1SInAqQlR ETbOCiXwcQ0yml3tp/wcQC9kROUWmANXlkS6hPdZ6R096pp8ShG3CoBXBw7cPg== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1777043757; a=rsa-sha256; cv=none; b=b5AKUDnOJK7scqFJ+fq+Mzy079d3ClQXQJYvzl8nOEoAZA4iHBN+ryjNLYhv7ireu98jcg owY1kCA6WKZlURkSStu8BDF7Cj6tFnthdYyoShoDraA4JVxrzICIhyBVB0vW5qkuENjs5b r6wRKx748VII4tUrl76amaP3cTI6Iq5lY5AzlJRv5GFdAo90mF05EQz1+xJdBftCYp9x2g 8OzaWKM1b7sG81H3PO87He0WNS5xhPTJR/hVY0AOKms9jVkRcu0VZtsHsNC7KIVMrSgAdn 5BlYwIvAzFvsewRx8ZAXWrr+vLJHQFJraNqkJOUasrBqkGvvXvXFctxUUCjf6Q== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1777043757; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=+h4HlcJTbOMYbGuIpTcNMNA8U5/XAoEZtOP6m07p9q8=; b=soAZHCoj68jCdM4foM1j81wMqTp7xCQEc2Z82C7jGJDBYlqAHWdaYZq9k3K+QKa998W5iT lXd0WfriUBpqkA1a0950zzJwnrp5K94gCAbM+b/Q9rzY475ZsskDvRHo6svBjrIFG+yumX AD5W311GhJ7W/b9oClRWOUQT6UJF01pPjy/ymRpWg7fNiDiV1Gma4qF2tEcQdsp+DOVEYn 1ILSIBvDyGQOZj2mu5qxcQgo7k11oKT5rew9vZaBngH931xsROq/JumXzNOvm8Qrp9Xogj GY2/jKV+GdkwAfRPtsyMP5mo+wj9uPoh7D7gRYmJHoVLhKPTka4OJmoBSNtMKQ== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) by mxrelay.nyi.freebsd.org (Postfix) with ESMTP id 4g2GkP2nBGz17QL for ; Fri, 24 Apr 2026 15:15:57 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from git (uid 1279) (envelope-from git@FreeBSD.org) id 32bd4 by gitrepo.freebsd.org (DragonFly Mail Agent v0.13+ on gitrepo.freebsd.org); Fri, 24 Apr 2026 15:15:52 +0000 To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org From: Vladimir Kondratyev Subject: git: 87ed6840a0a6 - main - rtlbtfw(8): Load firmware from filesystem with mmap() List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: wulf X-Git-Repository: src X-Git-Refname: refs/heads/main X-Git-Reftype: branch X-Git-Commit: 87ed6840a0a6320295f6abb43a987d20ae126cf7 Auto-Submitted: auto-generated Date: Fri, 24 Apr 2026 15:15:52 +0000 Message-Id: <69eb8928.32bd4.7043e25@gitrepo.freebsd.org> The branch main has been updated by wulf: URL: https://cgit.FreeBSD.org/src/commit/?id=87ed6840a0a6320295f6abb43a987d20ae126cf7 commit 87ed6840a0a6320295f6abb43a987d20ae126cf7 Author: Vladimir Kondratyev AuthorDate: 2026-04-24 15:15:22 +0000 Commit: Vladimir Kondratyev CommitDate: 2026-04-24 15:15:22 +0000 rtlbtfw(8): Load firmware from filesystem with mmap() rather than with read() to alleviate concerns about partial reads. --- usr.sbin/bluetooth/rtlbtfw/rtlbt_fw.c | 21 +++++++-------------- 1 file changed, 7 insertions(+), 14 deletions(-) diff --git a/usr.sbin/bluetooth/rtlbtfw/rtlbt_fw.c b/usr.sbin/bluetooth/rtlbtfw/rtlbt_fw.c index d7e9f2f939c6..aadd254571bb 100644 --- a/usr.sbin/bluetooth/rtlbtfw/rtlbt_fw.c +++ b/usr.sbin/bluetooth/rtlbtfw/rtlbt_fw.c @@ -29,6 +29,7 @@ #include #include +#include #include #include @@ -166,8 +167,7 @@ rtlbt_fw_read(struct rtlbt_firmware *fw, const char *fwname) { int fd; struct stat sb; - unsigned char *buf; - ssize_t r; + unsigned char *buf, *mmap_addr; fd = open(fwname, O_RDONLY); if (fd < 0) { @@ -188,23 +188,16 @@ rtlbt_fw_read(struct rtlbt_firmware *fw, const char *fwname) return (0); } - /* XXX handle partial reads */ - r = read(fd, buf, sb.st_size); - if (r < 0) { - warn("%s: read", __func__); + mmap_addr = mmap(NULL, sb.st_size, PROT_READ, MAP_SHARED, fd, 0); + if (mmap_addr == MAP_FAILED) { + warn("%s: mmap: %s", __func__, fwname); free(buf); close(fd); return (0); } - if (r != sb.st_size) { - rtlbt_err("read len %d != file size %d", - (int) r, - (int) sb.st_size); - free(buf); - close(fd); - return (0); - } + memcpy(buf, mmap_addr, sb.st_size); + munmap(mmap_addr, sb.st_size); /* We have everything, so! */