From owner-p4-projects@FreeBSD.ORG Wed May 24 03:50:27 2006 Return-Path: X-Original-To: p4-projects@freebsd.org Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 3B50216A62E; Wed, 24 May 2006 03:50:27 +0000 (UTC) X-Original-To: perforce@freebsd.org Delivered-To: perforce@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id B2C7B16A66C; Wed, 24 May 2006 03:50:26 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (66-23-211-162.clients.speedfactory.net [66.23.211.162]) by mx1.FreeBSD.org (Postfix) with ESMTP id 296F943D45; Wed, 24 May 2006 03:50:25 +0000 (GMT) (envelope-from jhb@freebsd.org) Received: from osx.baldwin.cx (osx.baldwin.cx [192.168.0.15]) (authenticated bits=0) by server.baldwin.cx (8.13.4/8.13.4) with ESMTP id k4O3oOlg084612; Tue, 23 May 2006 23:50:24 -0400 (EDT) (envelope-from jhb@freebsd.org) From: John Baldwin To: John Birrell Date: Tue, 23 May 2006 23:50:13 -0400 User-Agent: KMail/1.9.1 References: <200605222015.k4MKFVIH004583@repoman.freebsd.org> In-Reply-To: <200605222015.k4MKFVIH004583@repoman.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-15" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200605232350.14614.jhb@freebsd.org> X-Virus-Scanned: ClamAV 0.87.1/1478/Mon May 22 17:01:38 2006 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-3.9 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 autolearn=ham version=3.1.0 X-Spam-Checker-Version: SpamAssassin 3.1.0 (2005-09-13) on server.baldwin.cx Cc: Perforce Change Reviews Subject: Re: PERFORCE change 97634 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 24 May 2006 03:50:28 -0000 On Monday 22 May 2006 16:15, John Birrell wrote: > http://perforce.freebsd.org/chv.cgi?CH=97634 > > Change 97634 by jb@jb_freebsd2 on 2006/05/22 20:15:14 > > Change the kernel linker to use an sx lock instead of a mutex so that > DTrace can list all linker files while holding the lock and still be > able to malloc with wait to create probes. > > Add a function to list the function names and their values. This function > assumes that the lock is held while listing the files, so no additional > locking is attempted. I need to give you my kernel linker locking patch to avoid future pain. It fixes the kernel linker lock to actually protect all of the linker and adds a foreach-style function to call a handler on each linker_file_t. I haven't committed it yet as it needs testing with ndis. Maybe I will post it to current@ tomorrow. -- John Baldwin