From owner-svn-src-all@FreeBSD.ORG Wed Mar 5 13:22:58 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 178296C6; Wed, 5 Mar 2014 13:22:58 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id DDE4F920; Wed, 5 Mar 2014 13:22:57 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1WLBmd-000MfS-CA; Wed, 05 Mar 2014 13:22:51 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id s25DMmpe049328; Wed, 5 Mar 2014 06:22:48 -0700 (MST) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/r4bef9J1SABWAKS+By9OM Subject: Re: svn commit: r262411 - head/sys/arm/arm From: Ian Lepore To: Konstantin Belousov In-Reply-To: <20140305115402.GC24664@kib.kiev.ua> References: <201402232252.s1NMqmI5075701@svn.freebsd.org> <20140305115402.GC24664@kib.kiev.ua> Content-Type: text/plain; charset="us-ascii" Date: Wed, 05 Mar 2014 06:22:47 -0700 Message-ID: <1394025767.1149.327.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 05 Mar 2014 13:22:58 -0000 On Wed, 2014-03-05 at 13:54 +0200, Konstantin Belousov wrote: > On Sun, Feb 23, 2014 at 10:52:48PM +0000, Ian Lepore wrote: > > Author: ian > > Date: Sun Feb 23 22:52:48 2014 > > New Revision: 262411 > > URL: http://svnweb.freebsd.org/changeset/base/262411 > > > > Log: > > If the L2 cache type is PIPT, pass a physical address for a flush. > > > > While this is technically more correct, I don't think it much matters, > > because the only thing in the tree that calls cpu_flush_dcache() is md(4) > > and I'm > 99% sure it's bogus that it does so; md has no ability to do > > anything that can perturb data cache coherency. > > Yes, md(4) does not break data cache coherency, but I think that > Marcel added the flush to ensure instruction cache coherency. The > intent was to ensure that harward-architecture machines would > see up-to-date memory content when fetching instructions after > read on md(4). Oh. If that's necessary on ia64, it seems like ia64/elf_machdep.c would be the place to do the flush. -- Ian