From owner-cvs-all Tue Apr 4 5:40:12 2000 Delivered-To: cvs-all@freebsd.org Received: from critter.freebsd.dk (critter.freebsd.dk [212.242.40.131]) by hub.freebsd.org (Postfix) with ESMTP id 7FAD937B729; Tue, 4 Apr 2000 05:39:58 -0700 (PDT) (envelope-from phk@critter.freebsd.dk) Received: from critter.freebsd.dk (localhost.freebsd.dk [127.0.0.1]) by critter.freebsd.dk (8.9.3/8.9.3) with ESMTP id OAA27009; Tue, 4 Apr 2000 14:39:40 +0200 (CEST) (envelope-from phk@critter.freebsd.dk) To: Bruce Evans Cc: "Justin T. Gibbs" , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/kern kern_mib.c vfs_bio.c src/sys/sys buf.h In-reply-to: Your message of "Tue, 04 Apr 2000 22:29:29 +1000." Date: Tue, 04 Apr 2000 14:39:40 +0200 Message-ID: <27007.954851980@critter.freebsd.dk> From: Poul-Henning Kamp Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message , Bruce Ev ans writes: >> I will propose we stick to just one field in struct bio: a 64bit >> byte offset, we may want to keep a blkno around in struct buf, >> but lets decide that separately. > >This requires more widespread changes to convert block numbers to offsets >in all file systems, and normally gives 2 extra sets of conversions: No, we can populate the bio_offset in specfs::strategy if it isn't already, we don't need to touch any filesystems for this: if (!(bp->b_FLAGS & B_PHYS)) bp->bio_offset = bp->b_blkno << DEV_BSIZE; -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message