From owner-freebsd-bugs@freebsd.org Wed Oct 21 18:15:12 2015 Return-Path: Delivered-To: freebsd-bugs@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id B0C25A1A569 for ; Wed, 21 Oct 2015 18:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2001:1900:2254:206a::16:76]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 9D1591126 for ; Wed, 21 Oct 2015 18:15:12 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from bugs.freebsd.org ([127.0.1.118]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id t9LIFCIV013031 for ; Wed, 21 Oct 2015 18:15:12 GMT (envelope-from bugzilla-noreply@freebsd.org) From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203940] makefs: Coverity CID 976847: Delayed error with output file type Date: Wed, 21 Oct 2015 18:15:12 +0000 X-Bugzilla-Reason: AssignedTo X-Bugzilla-Type: new X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Base System X-Bugzilla-Component: bin X-Bugzilla-Version: 11.0-CURRENT X-Bugzilla-Keywords: X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: scdbackup@gmx.net X-Bugzilla-Status: New X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: freebsd-bugs@FreeBSD.org X-Bugzilla-Target-Milestone: --- X-Bugzilla-Flags: X-Bugzilla-Changed-Fields: bug_id short_desc product version rep_platform op_sys bug_status bug_severity priority component assigned_to reporter Message-ID: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Oct 2015 18:15:12 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203940 Bug ID: 203940 Summary: makefs: Coverity CID 976847: Delayed error with output file type Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/cd9660/cd9660_write.c CID 976847 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) 4. negative_returns: curpos is passed to a parameter that cannot be negative. [Note: The source code implementation of the function hasi been overridden by a builtin model.] 406 curpos = ftello(fd); 413 if (fseeko(fd, curpos, SEEK_SET) == -1) --------------- Source analysis: This gesture lacks of an error check. The fseeko() call has one 413 if (fseeko(fd, curpos, SEEK_SET) == -1) 414 err(1, "fseeko"); It is not easy to imagine how a file pointer which is not suitable for ftello() should get here, as makefs obviously is not prepared for sequential output. --------------- Remedy proposal: It cannot harm to show the user the direct error cause and not an error of the subsequent fseeko(SEEK_SET). curpos = ftello(fd); + if (curpos < 0) + err(1, "ftello"); -- You are receiving this mail because: You are the assignee for the bug.