Date: Wed, 21 Oct 2015 18:15:12 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-bugs@FreeBSD.org Subject: [Bug 203940] makefs: Coverity CID 976847: Delayed error with output file type Message-ID: <bug-203940-8@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=203940 Bug ID: 203940 Summary: makefs: Coverity CID 976847: Delayed error with output file type Product: Base System Version: 11.0-CURRENT Hardware: Any OS: Any Status: New Severity: Affects Some People Priority: --- Component: bin Assignee: freebsd-bugs@FreeBSD.org Reporter: scdbackup@gmx.net usr.sbin/makefs/cd9660/cd9660_write.c CID 976847 (#1 of 1): Argument cannot be negative (NEGATIVE_RETURNS) 4. negative_returns: curpos is passed to a parameter that cannot be negative. [Note: The source code implementation of the function hasi been overridden by a builtin model.] 406 curpos = ftello(fd); 413 if (fseeko(fd, curpos, SEEK_SET) == -1) --------------- Source analysis: This gesture lacks of an error check. The fseeko() call has one 413 if (fseeko(fd, curpos, SEEK_SET) == -1) 414 err(1, "fseeko"); It is not easy to imagine how a file pointer which is not suitable for ftello() should get here, as makefs obviously is not prepared for sequential output. --------------- Remedy proposal: It cannot harm to show the user the direct error cause and not an error of the subsequent fseeko(SEEK_SET). curpos = ftello(fd); + if (curpos < 0) + err(1, "ftello"); -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-203940-8>