From owner-svn-src-all@freebsd.org Fri Aug 28 12:09:51 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 74D003D78D2; Fri, 28 Aug 2020 12:09:51 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4BdJLk3bRTz4TQb; Fri, 28 Aug 2020 12:09:50 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from tom.home (kib@localhost [127.0.0.1]) by kib.kiev.ua (8.16.1/8.16.1) with ESMTPS id 07SC9ahH055466 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384 bits=256 verify=NO); Fri, 28 Aug 2020 15:09:39 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.10.3 kib.kiev.ua 07SC9ahH055466 Received: (from kostik@localhost) by tom.home (8.16.1/8.16.1/Submit) id 07SC9aVc055465; Fri, 28 Aug 2020 15:09:36 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Fri, 28 Aug 2020 15:09:36 +0300 From: Konstantin Belousov To: Adrian Chadd Cc: src-committers , svn-src-all , svn-src-head Subject: Re: svn commit: r364091 - head/lib/libc/gen Message-ID: <20200828120936.GC2713@kib.kiev.ua> References: <202008102141.07ALfnDj009838@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Spam-Status: No, score=-1.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FORGED_GMAIL_RCVD,FREEMAIL_FROM, NML_ADSP_CUSTOM_MED autolearn=no autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on tom.home X-Rspamd-Queue-Id: 4BdJLk3bRTz4TQb X-Spamd-Bar: / Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=fail reason="No valid SPF, No valid DKIM" header.from=gmail.com (policy=none); spf=softfail (mx1.freebsd.org: 2001:470:d5e7:1::1 is neither permitted nor denied by domain of kostikbel@gmail.com) smtp.mailfrom=kostikbel@gmail.com X-Spamd-Result: default: False [0.70 / 15.00]; RCVD_TLS_ALL(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; FREEMAIL_FROM(0.00)[gmail.com]; NEURAL_HAM_LONG(-0.16)[-0.163]; TAGGED_RCPT(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_XAW(0.00)[]; R_SPF_SOFTFAIL(0.00)[~all]; NEURAL_SPAM_MEDIUM(0.35)[0.350]; TO_MATCH_ENVRCPT_SOME(0.00)[]; TO_DN_ALL(0.00)[]; NEURAL_SPAM_SHORT(0.51)[0.512]; FREEMAIL_TO(0.00)[gmail.com]; FROM_EQ_ENVFROM(0.00)[]; R_DKIM_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; ASN(0.00)[asn:6939, ipnet:2001:470::/32, country:US]; RCVD_COUNT_TWO(0.00)[2]; MAILMAN_DEST(0.00)[svn-src-all,svn-src-head]; DMARC_POLICY_SOFTFAIL(0.10)[gmail.com : No valid SPF, No valid DKIM,none] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.33 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Aug 2020 12:09:51 -0000 On Thu, Aug 27, 2020 at 05:28:03PM -0700, Adrian Chadd wrote: > Hi! > > This breaks when compiling FreeBSD-mips on GCC-9. :( > > In file included from > /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/gen/scandir.c:50, > from > /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/gen/scandir_b.c:29: > /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/include/block_abi.h:45:2: > error: anonymous struct declared inside parameter list will not be visible > outside of this definition or declarati > 45 | struct {\ > | ^~~~~~ > /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/gen/scandir.c:67:5: > note: in expansion of macro 'DECLARE_BLOCK' > 67 | DECLARE_BLOCK(int, dcomp, const struct dirent **, const struct > dirent **)) > | ^~~~~~~~~~~~~ > /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/include/block_abi.h:45:2: > error: anonymous struct declared inside parameter list will not be visible > outside of this definition or declarati > 45 | struct {\ > | ^~~~~~ > /usr/home/adrian/work/freebsd/head-embedded/src/lib/libc/gen/scandir.c:66:5: > note: in expansion of macro 'DECLARE_BLOCK' > 66 | DECLARE_BLOCK(int, select, const struct dirent *), > | ^~~~~~~~~~~~~ > cc1: all warnings being treated as errors > --- scandir_b.o --- > *** [scandir_b.o] Error code 1 You did not show the exact command line for your compilation failure. Since gcc does not support blocks, I think the best route is to add something like the following to lib/libc/gen/Makefile.inc: CWARNFLAGS.gcc.scandir_b.c= -Wno-error (I did not even tried to test it).