From owner-dev-commits-src-all@freebsd.org Tue Jun 22 11:36:29 2021 Return-Path: Delivered-To: dev-commits-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id BB95865C393 for ; Tue, 22 Jun 2021 11:36:29 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4G8PVj4gNTz4TtD for ; Tue, 22 Jun 2021 11:36:29 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: by mail-wr1-f47.google.com with SMTP id e22so19690467wrc.1 for ; Tue, 22 Jun 2021 04:36:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=XGNIqLkRo0UVwlJselYXpTEeqYzb4toysXR4N/WYSvE=; b=Bvm8IjYqwFRaa/TJHCsOq6Yjc1pVwGu2s1QnYTe5gQTgGQ4qKe5S239/yWI48ZpFAn icpRfYM3QgbMFAKC7MYWwhBW0/0z6iCC/38TzFSzreLaJZKr7CqWqYEvlHK1CUrTtkZW jnfgP1XuFaySdQFRdvijt406aijZxWsPp+zNpddSreeAe5VGDE+t/ahxmEUIfPl7PivX 77L7HbkmBSiKbBfkuE1uhUK/fXWfy/GLmHTrHEaYlrnFQjdja0D4r+vWSisrabTJG51K I0z+Ibgn6q3X3uafvpCllSoJHiyLhfkZCFuwva3gcu4LpIzRXMCBAZ+xiCz8rLTu8lMS eu4g== X-Gm-Message-State: AOAM530mp2rCy22d6IqvtBCRTGH7g/bc6VRHq9vvx918lhKPymBM8hoD lsVXw6GILJrSluW8yeVTD8eeTNaP3JP43ejB X-Google-Smtp-Source: ABdhPJyUQ9jb0FiGt6IFUcrDhSWLeIUEOkWekmTnkrQsG5VB2f35tMusEnwUyoyueZetCoLArr+UIQ== X-Received: by 2002:adf:f20c:: with SMTP id p12mr4132538wro.257.1624361788084; Tue, 22 Jun 2021 04:36:28 -0700 (PDT) Received: from smtpclient.apple (trinity-students-nat.trin.cam.ac.uk. [131.111.193.104]) by smtp.gmail.com with ESMTPSA id p11sm11415159wre.57.2021.06.22.04.36.27 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 22 Jun 2021 04:36:27 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.100.0.2.22\)) Subject: Re: git: e013e36939ac - main - linux(4): Get rid of Linuxulator kernel build options. From: Jessica Clarke In-Reply-To: Date: Tue, 22 Jun 2021 12:36:26 +0100 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Transfer-Encoding: quoted-printable Message-Id: <4C0E8010-EFBF-42A5-90EF-A502E7BBD3D7@freebsd.org> References: <202106211656.15LGuXQU059224@gitrepo.freebsd.org> To: Dmitry Chagin X-Mailer: Apple Mail (2.3654.100.0.2.22) X-Rspamd-Queue-Id: 4G8PVj4gNTz4TtD X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Commit messages for all branches of the src repository List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jun 2021 11:36:29 -0000 On 22 Jun 2021, at 12:01, Dmitry Chagin wrote: > On Mon, Jun 21, 2021 at 10:56:38PM +0100, Jessica Clarke wrote: >> On 21 Jun 2021, at 17:56, Dmitry Chagin wrote: >>>=20 >>> The branch main has been updated by dchagin: >>>=20 >>> URL: = https://cgit.FreeBSD.org/src/commit/?id=3De013e36939ac87b53195370fb5e29f29= c1a4b5c6 >>>=20 >>> commit e013e36939ac87b53195370fb5e29f29c1a4b5c6 >>> Author: Dmitry Chagin >>> AuthorDate: 2021-06-22 05:32:39 +0000 >>> Commit: Dmitry Chagin >>> CommitDate: 2021-06-22 05:32:39 +0000 >>>=20 >>> linux(4): Get rid of Linuxulator kernel build options. >>>=20 >>> Stop confusing people, retire COMPAT_LINUX and COMPAT_LINUX32 = kernel >>> build options. Since we have 32 and 64 bit Linux emulators, we = can't build both >>> emulators together into the kernel. I don't think it matters, = Linux emulation >>> depends on loadable modules (via rc). >>>=20 >>> Cut LINPROCFS and LINSYSFS for consistency. >>=20 >> I don=E2=80=99t see why these two should be deleted? They currently = build fine, >> and GNU/kFreeBSD kernels enable them. They might work as modules, but = I >> would worry that too many parts of userland would try and read them >> before /etc/init.d/kldutils (the init script that loads modules) = loads >> them, so then we=E2=80=99d have to mess around with GRUB configs to = preload >> them. If the options work, please leave them in. >>=20 >=20 > both FS modules depend on linux.ko on i386 or linux_common.ko on = amd64, > so it doesn't make sense to have options for them But that still worked, and was even in NOTES so being tested by LINT. >> There=E2=80=99s a separate debate of whether this is the =E2=80=9Cright= =E2=80=9D fix for >> COMPAT_LINUX*; arguably that *should* work and it=E2=80=99s a bug = that they >> don=E2=80=99t, not a feature, even if it=E2=80=99s not of much = interest to support=E2=80=A6 >>=20 >> I=E2=80=99d like to see the second half reverted, please, and believe = the first >> should be too, but I feel less strongly about that. >>=20 >=20 > I think that descendants should adapt to upstream, esp since there is = no > KBI or ABI breakage. btw, debian wiki says gnu/kFreeBSD unmaintained > since 2014. That is the reason to worry about dead project? As the current maintainer this is news to me. I see no such comment on the port=E2=80=99s wiki page[1]. Jess [1] https://wiki.debian.org/Debian_GNU/kFreeBSD