From owner-freebsd-java@FreeBSD.ORG Fri May 2 10:44:04 2003 Return-Path: Delivered-To: freebsd-java@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id D692637B43A for ; Fri, 2 May 2003 10:44:04 -0700 (PDT) Received: from mgr2.xmission.com (mgr2.xmission.com [198.60.22.202]) by mx1.FreeBSD.org (Postfix) with ESMTP id D0E7043FAF for ; Fri, 2 May 2003 10:44:03 -0700 (PDT) (envelope-from glewis@eyesbeyond.com) Received: from mail by mgr2.xmission.com with spam-scanned (Exim 3.35 #1) id 19BeIe-0003ih-02 for freebsd-java@freebsd.org; Fri, 02 May 2003 11:26:20 -0600 Received: from [207.135.128.145] (helo=misty.eyesbeyond.com) by mgr2.xmission.com with esmtp (Exim 3.35 #1) id 19BeBA-0000R8-02; Fri, 02 May 2003 11:18:37 -0600 Received: from misty.eyesbeyond.com (localhost.eyesbeyond.com [127.0.0.1]) by misty.eyesbeyond.com (8.12.9/8.12.9) with ESMTP id h42HN3Qf005790; Fri, 2 May 2003 11:23:04 -0600 (MDT) (envelope-from glewis@eyesbeyond.com) Received: (from glewis@localhost) by misty.eyesbeyond.com (8.12.9/8.12.9/Submit) id h42HN0GH005789; Fri, 2 May 2003 11:23:00 -0600 (MDT) X-Authentication-Warning: misty.eyesbeyond.com: glewis set sender to glewis@eyesbeyond.com using -f Date: Fri, 2 May 2003 11:23:00 -0600 From: Greg Lewis To: Ernst de Haan Message-ID: <20030502172300.GA5567@misty.eyesbeyond.com> References: <20030501190202.S93849@puget.esil.univ-mrs.fr> <200305020925.12974.ernst.dehaan@nl.wanadoo.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200305020925.12974.ernst.dehaan@nl.wanadoo.com> User-Agent: Mutt/1.4.1i X-Spam-Status: No, hits=-3.5 required=8.0 tests=IN_REP_TO,QUOTED_EMAIL_TEXT,REFERENCES, SIGNATURE_SHORT_DENSE,SPAM_PHRASE_00_01,USER_AGENT, USER_AGENT_MUTT,X_AUTH_WARNING version=2.43 X-Spam-Level: cc: Herve Quiroz cc: freebsd-java@freebsd.org Subject: Re: bsd.java.mk: USE_ANT X-BeenThere: freebsd-java@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Porting Java to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 May 2003 17:44:05 -0000 On Fri, May 02, 2003 at 09:25:12AM +0200, Ernst de Haan wrote: > Sounds like a good proposal, Herve! > Anyone else have any comments? Seems like a good addition to me. Some comments below. > On Thursday 01 May 2003 19:09, Herve Quiroz wrote: > > We discussed this point long time ago but I can't remember we did agree > > on some way of implementing Ant support in bsd.java.mk. > > > > Most ports that build using ant do the following: > > > > - Set the Ant build dependency > > > > - Set the Ant executable (ANT) > > > > - Set the Ant targets (ANT_TARGET) > > > > - Possibly set the Ant options (ANT_ARGS) I would add ANT_ENV since ant currently respects some environment variables (specifically, JAVACMD, ANT_OPTS and ANT_ARGS). It may support more in future. Is it worth adding a convenience ANT_BUILDFILE setting? I realise people could do the same thing with ANT_ARGS, just looking at the options for make and seeing MAKEFILE can be set. > > And then in the do-build: > > > > ${ANT} [${ANT_ARGS}] ${ANT_TARGET} If ANT_ARGS is set in the environment then ant should just pick it up from there ;). > > What if we just put this "limited" ant support in bsd.java.mk ? > > > > So you just have to do the following: > > > > USE_ANT=yes > > ANT_ARGS+= -Dnoget=yes > > ANT_TARGET= jar > > .if defined(NOPORTDOCS) > > ANT_TARGET+= docs > > .else > > ANT_TARGET+= docs > > .endif > > > > What do you think of it ? I like it. -- Greg Lewis Email : glewis@eyesbeyond.com Eyes Beyond Web : http://www.eyesbeyond.com Information Technology FreeBSD : glewis@FreeBSD.org