From owner-freebsd-current@FreeBSD.ORG  Tue Mar  1 17:17:16 2011
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84CF81065672;
	Tue,  1 Mar 2011 17:17:16 +0000 (UTC)
	(envelope-from rdivacky@vlk.vlakno.cz)
Received: from vlakno.cz (lev.vlakno.cz [77.93.215.190])
	by mx1.freebsd.org (Postfix) with ESMTP id 37DBD8FC0A;
	Tue,  1 Mar 2011 17:17:15 +0000 (UTC)
Received: from lev.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id 14A999CB0D0;
	Tue,  1 Mar 2011 18:17:14 +0100 (CET)
X-Virus-Scanned: amavisd-new at vlakno.cz
Received: from vlakno.cz ([127.0.0.1])
	by lev.vlakno.cz (lev.vlakno.cz [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id LBUP+50VngeW; Tue,  1 Mar 2011 18:17:13 +0100 (CET)
Received: from vlk.vlakno.cz (localhost [127.0.0.1])
	by vlakno.cz (Postfix) with ESMTP id DE5229CB349;
	Tue,  1 Mar 2011 18:17:12 +0100 (CET)
Received: (from rdivacky@localhost)
	by vlk.vlakno.cz (8.14.4/8.14.4/Submit) id p21HHCNM064858;
	Tue, 1 Mar 2011 18:17:12 +0100 (CET) (envelope-from rdivacky)
Date: Tue, 1 Mar 2011 18:17:12 +0100
From: Roman Divacky <rdivacky@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Message-ID: <20110301171712.GA64489@freebsd.org>
References: <20110228203928.GA93494@freebsd.org>
	<201103010754.14686.jhb@freebsd.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201103010754.14686.jhb@freebsd.org>
User-Agent: Mutt/1.4.2.3i
Cc: freebsd-current@freebsd.org, current@freebsd.org
Subject: Re: [TESTING]: boot2 changes
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 01 Mar 2011 17:17:16 -0000

On Tue, Mar 01, 2011 at 07:54:14AM -0500, John Baldwin wrote:
> On Monday, February 28, 2011 3:39:28 pm Roman Divacky wrote:
> > 3) it changes the first keyhit limit to 5 seconds from 3
> >    so that constant propagation can take place
> 
> Does this make booting take 2 seconds longer as a result?
> 
> I'm curious as to why '3*FOO' isn't a constant but '5*FOO' is?

I worded it wrong, the point being that if the argument is the same
in all callsites the compiler can turn it into a constant and propagate
that to the function.

I will remove this as it saves just 8 bytes... thank you for the review!

roman