Date: Wed, 20 Apr 2022 15:37:10 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 263159] [NEW PORT] games/solver Math quiz game Message-ID: <bug-263159-7788-WiHeNlJfyP@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-263159-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-263159-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D263159 --- Comment #5 from Robert Clausecker <fuz@fuz.su> --- (In reply to modex from comment #4) > https://cgit.freebsd.org/ports/tree/graphics/acidwarp/Makefile Contrary to my expectation, this method works, too (I've just checked). It= 's just somewhat unconventional. Feel free to leave it the way it is. > No particular reason. Do you suggest I change this or does this matter? Yes, please remove the ?=3D unless there is a specific reason to keep it.=20 Generally, ?=3D should be used if the variable is one the user is expected = to set, such as CFLAGS. LIB_DEPENDS is not such a variable. > It is the nature of svgalib. For a non-root user to use an svgalib applic= ation this must be set. This makes sense. Consider changing the description of the SETUID option i= n a way that this is clear. E.g. "Install setuid root to access VGA device" = or something. > I will give this a shot as well and re-upload the shar with the changes.= Thank you. Note that if you switch to using git correctly (i.e. having the source file= s in git, not the tarball), then this won't be needed. When github generates tarballs (which you can use using USE_GITHUB), it automatically puts in a t= op level directory. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-263159-7788-WiHeNlJfyP>