From owner-svn-src-stable-11@freebsd.org Thu Mar 2 02:06:28 2017 Return-Path: Delivered-To: svn-src-stable-11@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 19935CF47A9; Thu, 2 Mar 2017 02:06:28 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (br1.CN84in.dnsmgr.net [69.59.192.140]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id D4DBED5E; Thu, 2 Mar 2017 02:06:27 +0000 (UTC) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: from pdx.rh.CN85.dnsmgr.net (localhost [127.0.0.1]) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3) with ESMTP id v2226QX4060131; Wed, 1 Mar 2017 18:06:26 -0800 (PST) (envelope-from freebsd-rwg@pdx.rh.CN85.dnsmgr.net) Received: (from freebsd-rwg@localhost) by pdx.rh.CN85.dnsmgr.net (8.13.3/8.13.3/Submit) id v2226QGL060130; Wed, 1 Mar 2017 18:06:26 -0800 (PST) (envelope-from freebsd-rwg) From: "Rodney W. Grimes" Message-Id: <201703020206.v2226QGL060130@pdx.rh.CN85.dnsmgr.net> Subject: Re: svn commit: r314525 - in stable/11/sys: arm/arm arm/include conf In-Reply-To: <201703012245.v21MjCkC054978@repo.freebsd.org> To: Ian Lepore Date: Wed, 1 Mar 2017 18:06:26 -0800 (PST) CC: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-11@freebsd.org X-Mailer: ELM [version 2.4ME+ PL121h (25)] MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII X-BeenThere: svn-src-stable-11@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for only the 11-stable src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 02 Mar 2017 02:06:28 -0000 > Author: ian > Date: Wed Mar 1 22:45:12 2017 > New Revision: 314525 > URL: https://svnweb.freebsd.org/changeset/base/314525 ... > > Modified: stable/11/sys/conf/files.arm > ============================================================================== > --- stable/11/sys/conf/files.arm Wed Mar 1 21:58:26 2017 (r314524) > +++ stable/11/sys/conf/files.arm Wed Mar 1 22:45:12 2017 (r314525) > @@ -53,7 +53,8 @@ arm/arm/gdb_machdep.c optional gdb > arm/arm/generic_timer.c optional generic_timer > arm/arm/gic.c optional gic > arm/arm/hdmi_if.m optional hdmi > -arm/arm/identcpu.c standard > +arm/arm/identcpu-v4.c optional !armv6 > +arm/arm/identcpu-v6.c optional armv6 > arm/arm/in_cksum.c optional inet | inet6 > arm/arm/in_cksum_arm.S optional inet | inet6 > arm/arm/intr.c optional !intrng > _______________________________________________ > svn-src-stable-11@freebsd.org mailing list > https://lists.freebsd.org/mailman/listinfo/svn-src-stable-11 > To unsubscribe, send any mail to "svn-src-stable-11-unsubscribe@freebsd.org" If we are adding armv4 as an optional supported cpu type (I didnt think we could run on anything less than an armv6, this patch clearly seems to make that false.) I think we should just do the above as > +arm/arm/identcpu-v4.c optional !armv6 | armv4 > +arm/arm/identcpu-v6.c optional armv6 As your above code would make the config for an armv6 machine be expressed by the lack of a CPU token in the CONFIG file, which is non intutive. -- Rod Grimes rgrimes@freebsd.org