From owner-freebsd-chat Sun Nov 24 17:19:19 2002 Delivered-To: freebsd-chat@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9B4C737B401 for ; Sun, 24 Nov 2002 17:19:18 -0800 (PST) Received: from mailsrv.otenet.gr (mailsrv.otenet.gr [195.170.0.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id 60F1E43E91 for ; Sun, 24 Nov 2002 17:19:17 -0800 (PST) (envelope-from keramida@ceid.upatras.gr) Received: from gothmog.gr (patr530-b147.otenet.gr [212.205.244.155]) by mailsrv.otenet.gr (8.12.6/8.12.6) with ESMTP id gAP1JEYh002165; Mon, 25 Nov 2002 03:19:15 +0200 (EET) Received: from gothmog.gr (gothmog [127.0.0.1]) by gothmog.gr (8.12.6/8.12.6) with ESMTP id gAP1JDLP017608; Mon, 25 Nov 2002 03:19:14 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Received: (from keramida@localhost) by gothmog.gr (8.12.6/8.12.6/Submit) id gAP1JD3a017607; Mon, 25 Nov 2002 03:19:13 +0200 (EET) (envelope-from keramida@ceid.upatras.gr) Date: Mon, 25 Nov 2002 03:19:13 +0200 From: Giorgos Keramidas To: Terry Lambert Cc: freebsd-chat@FreeBSD.ORG Subject: Re: Style(9) question Message-ID: <20021125011913.GH15728@gothmog.gr> References: <20021122193040.GA23078@dogma.freebsd-uk.eu.org> <20021122214405.GA11011@HAL9000.homeunix.com> <8gof8g83w4.f8g@localhost.localdomain> <20021124090603.GA3172@HAL9000.homeunix.com> <20021124100846.GC51850@raggedclown.net> <20021124162717.GA576@gothmog.gr> <3DE1739B.5AD2AEA7@mindspring.com> <20021125010242.GE15728@gothmog.gr> <3DE178ED.6883CEC2@mindspring.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <3DE178ED.6883CEC2@mindspring.com> Sender: owner-freebsd-chat@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.org On 2002-11-24 17:12, Terry Lambert wrote: > Giorgos Keramidas wrote: > > I am more in favor of fixing any style issues, then commiting the > > fix, and closing the PR with a notice to the spirit of "I have > > changed the diff a bitt, because of `foo', and have committed it > > in revision x.y.z of `bar'." > > This is good too. It puts the style(9) compliance onus onto > people who care. :) > The issue, though, was rejection of bug fixes on the basis of > style(9). Which is hopefully answered above. We can have both. The committer who makes the changes is free to make changes to the diff, and bring it closer to style(9) either a) before committing the changes, or b) afterwards. The fact that there is an existing style is orthogonal to fixing of bugs. One can both fix bug and keep the existing style, or do either of the two, without necessarily depending on the other. > The heart of the issue is which of the two things is more > important: compliance with style(9), or the fixing of bugs. Both. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-chat" in the body of the message