Date: Sat, 18 Mar 2006 23:03:59 +0200 From: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> To: Ion-Mihai Tetcu <itetcu@people.tecnik93.com> Cc: Andreas Kohn <andreas@syndrom23.de>, Shaun Amott <shaun@inerd.com>, freebsd-ports-bugs@FreeBSD.org Subject: Re: ports/94288: [PATCH] misc/tinderbox: OPTIONaly depend on c[v]sup Message-ID: <20060318230359.0b933e00@it.buh.tecnik93.com> In-Reply-To: <20060318224424.66598f4d@it.buh.tecnik93.com> References: <200603181200.k2IC0f1J051666@freefall.freebsd.org> <20060318201314.GA1644@picobyte.net> <20060318223844.2969c56c@it.buh.tecnik93.com> <20060318224424.66598f4d@it.buh.tecnik93.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 18 Mar 2006 22:44:24 +0200
Ion-Mihai Tetcu <itetcu@people.tecnik93.com> wrote:
> On Sat, 18 Mar 2006 22:38:44 +0200
> Ion-Mihai Tetcu <itetcu@people.tecnik93.com> wrote:
>
> > On Sat, 18 Mar 2006 20:13:14 +0000
> > Shaun Amott <shaun@inerd.com> wrote:
> >
> > > On Sat, Mar 18, 2006 at 12:00:41PM +0000, Andreas Kohn wrote:
> > > >
> > > > I like the patch to enable cvsup/csup selection.
> > > > I think the unconditional RUN_DEPENDS on cvsup needs to get removed in
> > > > that case as well.
> > > > The patch for MySQL is incomplete, as setup-mysql.sh would still barf
> > > > about missing MySQL-ports.
> > > > The attached patch also fixes that, and sets USE_APACHE=3D1.3+ to stop
> > > > annoying apache2 users that apache13 is needed :)
> > > >
> > >
> > > Can we remove the apache dependency completely? Or, at least make it
> > > optional.
> >
> > Hard, since we use databases/pear-DB which pulls in php mod which pulls
> > in apache.
>
> ^^^ I didn't check this so I might be wrong, I don't remember what type
> of php pears pulls in.
>
> Well, we could add an OPTION:
>
> - ${LOCALBASE}/share/pear/DB.php:${PORTSDIR}/databases/pear-DB \
> ...
> + WEB_INTERFACE "Install experimental web interface" on
> ...
> - USE_APACHE= 1.3+
> ...
> .if defined(WITH_WEB_INTERFACE)
> USE_APACHE= 1.3+
> RUN_DEPENDS+= ${LOCALBASE}/share/pear/DB.php:${PORTSDIR}/databases/pear-DB
> .endif
and wrap the post-patch in .if defined(WITH_WEB_INTERFACE) too
--
IOnut - Unregistered ;) FreeBSD "user"
"Intellectual Property" is nowhere near as valuable as "Intellect"
There is an order of things in this universe.
-- Apollo, "Who Mourns for Adonais?" stardate 3468.1
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060318230359.0b933e00>