From owner-freebsd-hackers@FreeBSD.ORG Wed Jun 19 05:02:54 2013 Return-Path: Delivered-To: freebsd-hackers@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id E73BFE6D for ; Wed, 19 Jun 2013 05:02:54 +0000 (UTC) (envelope-from kostikbel@gmail.com) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) by mx1.freebsd.org (Postfix) with ESMTP id 5CD5E19CE for ; Wed, 19 Jun 2013 05:02:54 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id r5J52kgU034811; Wed, 19 Jun 2013 08:02:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua r5J52kgU034811 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id r5J52kbg034810; Wed, 19 Jun 2013 08:02:46 +0300 (EEST) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Wed, 19 Jun 2013 08:02:46 +0300 From: Konstantin Belousov To: Alfred Perlstein Subject: Re: please review, patch for lost camisr Message-ID: <20130619050246.GB91021@kib.kiev.ua> References: <51A44B0C.8010908@ixsystems.com> <201305281204.14146.jhb@freebsd.org> <51A505A5.7030105@ixsystems.com> <201305281613.32414.jhb@freebsd.org> <51A514F5.9050405@ixsystems.com> <20130529050835.GP3047@kib.kiev.ua> <51A592BC.1050100@mu.org> <20130529071645.GR3047@kib.kiev.ua> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="SuZWD+5recMkC1v4" Content-Disposition: inline In-Reply-To: <20130529071645.GR3047@kib.kiev.ua> User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: freebsd-hackers@freebsd.org X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Jun 2013 05:02:55 -0000 --SuZWD+5recMkC1v4 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, May 29, 2013 at 10:16:45AM +0300, Konstantin Belousov wrote: > Well, if you and I are right, the minimal patch should be >=20 > diff --git a/sys/kern/kern_intr.c b/sys/kern/kern_intr.c > index 8d63c9b..7c21015 100644 > --- a/sys/kern/kern_intr.c > +++ b/sys/kern/kern_intr.c > @@ -1349,7 +1349,7 @@ ithread_loop(void *arg) > * we are running, it will set it_need to note that we > * should make another pass. > */ > - while (ithd->it_need) { > + while (atomic_load_acq_int(&ithd->it_need)) { > /* > * This might need a full read and write barrier > * to make sure that this write posts before any >=20 So, was it tested ? If yes, did the patch helped ? --SuZWD+5recMkC1v4 Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.20 (FreeBSD) iQIcBAEBAgAGBQJRwTt1AAoJEJDCuSvBvK1B+AEQAIlcj0WnzAtd9xL4YaZbwWLa FLm9+klP5D4KBVU5rRP+6TQo+rfRJVjaoHo31KaxYcLhUlTdYTkHFAF0WZqdbovO AJ17mITHNlokdQWMOybXVIw5J5OnS1MejdcCASvLqA3gsgdkQRI3reaf4q5HjN8O fsXKk45V1Y60PlE0ptwZvwSKZ2MR0MxZlrrqyFLMOqhiUJfVJdsXLDgHx0NzXhVU hkxb4dq/+i6cEWoMyOdyVTcf5bI4eDwrPBFLLQ4rja+61kTKLMXkyTgopUXHtBdw Rse+VWsyLcM2XG3S//AMX+iBo1E0DU1PFjIPum1UeFJnsX9HeXAoiAA2GTSpZyLG obbpknZwnB6si/oBXDByveeipgzlEgBsy6acFK+CPaQN7vExMqJVlHIqxytXV33o svtQCglP2APoYmhZPYR5DW3av6+Gj/PsIEeDpM/gMUHOHRVBgKGmN9tvzs75j/aV mX0CJ+GwMu7xmbeDujlyneMcwowefaOOXdnyaTycbB7oGw12DKo0aZrR1nQoKGDU A81IRD+1hT22yRMx6M+RG/pNk8w9Mvqww8Qvo0IwKXRUlh+NAsyzFegFDzFZTXJF gwedIfwXm9JDvaHr0/Urwwq52fDCUPYLShEqKNeGVYi2vYBUGmkJRSa6IdsIMC1n j8GG1NXm57fvTaqQ7g7o =tFfw -----END PGP SIGNATURE----- --SuZWD+5recMkC1v4--