From owner-freebsd-stable@FreeBSD.ORG Wed Dec 20 02:16:27 2006 Return-Path: X-Original-To: freebsd-stable@freebsd.org Delivered-To: freebsd-stable@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 0779D16A416 for ; Wed, 20 Dec 2006 02:16:27 +0000 (UTC) (envelope-from dmagda@ee.ryerson.ca) Received: from toq12-srv.bellnexxia.net (toq12.bellnexxia.net [209.226.175.119]) by mx1.FreeBSD.org (Postfix) with ESMTP id 5D06D43C9F for ; Wed, 20 Dec 2006 02:16:25 +0000 (GMT) (envelope-from dmagda@ee.ryerson.ca) Received: from [192.168.1.133] ([67.71.54.177]) by tomts16-srv.bellnexxia.net (InterMail vM.5.01.06.13 201-253-122-130-113-20050324) with ESMTP id <20061219234517.ZTPB12977.tomts16-srv.bellnexxia.net@[192.168.1.133]>; Tue, 19 Dec 2006 18:45:17 -0500 In-Reply-To: <200612191407.kBJE7Vmq059475@lurza.secnetix.de> References: <200612191407.kBJE7Vmq059475@lurza.secnetix.de> Mime-Version: 1.0 (Apple Message framework v752.2) Content-Type: text/plain; charset=US-ASCII; delsp=yes; format=flowed Message-Id: Content-Transfer-Encoding: 7bit From: David Magda Date: Tue, 19 Dec 2006 18:45:15 -0500 To: freebsd-stable@freebsd.org, rsmith@xs4all.nl X-Mailer: Apple Mail (2.752.2) Cc: Subject: Re: ntpd flipping between PLL and FLL mode X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: David Magda List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Dec 2006 02:16:27 -0000 On Dec 19, 2006, at 09:07, Oliver Fromme wrote: > Roland Smith wrote: [...] >> The following patch to ntp_loopfilter.c should quell the message: >> -------------------- STFU patch -------------------- >> --- ntp_loopfilter.c.orig Tue Dec 19 14:13:25 2006 >> +++ ntp_loopfilter.c Tue Dec 19 14:14:02 2006 >> @@ -593,12 +593,6 @@ >> "kernel time sync disabled %04x", >> ntv.status); >> ntv.status &= ~(STA_PPSFREQ | STA_PPSTIME); >> - } else { >> - if (ntv.status != pll_status) >> - NLOG(NLOG_SYNCEVENT | NLOG_SYSEVENT) >> - msyslog(LOG_NOTICE, >> - "kernel time sync enabled %04x", >> - ntv.status); >> } >> pll_status = ntv.status; >> if (pll_nano) >> -------------------- STFU patch -------------------- > > I think it makes sense to replace LOG_NOTICE with LOG_DEBUG, > so you can still get at the messages if you really want to. > It's not necessary to remove the logging code alltogether. This bug has been reported to the NTP maintainers: https://ntp.isc.org/bugs/show_bug.cgi?id=452 It's been assigned to Harlan Stenn (stennntp.org). There have been no notes added to the bug report after the initial report on 2005-06-15.