From owner-dev-commits-src-main@freebsd.org Tue Dec 29 20:03:58 2020 Return-Path: Delivered-To: dev-commits-src-main@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 554344C9D12; Tue, 29 Dec 2020 20:03:58 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wr1-x436.google.com (mail-wr1-x436.google.com [IPv6:2a00:1450:4864:20::436]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4D55321fwtz3LK6; Tue, 29 Dec 2020 20:03:58 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wr1-x436.google.com with SMTP id c5so15595976wrp.6; Tue, 29 Dec 2020 12:03:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to; bh=VsFeMplfd2mLri5rvahdtG5Udoy8MtxqdbkpV3WFLPc=; b=h4gjdrIHptKcBIKRxzio8nL2O5oVn7YapDrJ6L4OTw7/VmbF0+cD9/h7oUH86EfOdN nkxcoecYN1F19knEZ9bqMk6eD/7Pv+uRNDAQ8sQXgF3WGZHWdYaaJpN3Do3ZBoED4vvm K3MSlAEpeIEQrM7zvx/kDE96WasZWPf8jPb8c+ntAJjqEw+wFjrF+RZaA/ZBIFGliooJ GWNM/8A4xKLvGjC8r2vl7wti1dTLTRUyaOw//62B72YVGx6XqEd03J8Sk9xA69AwOQCp 4L1OF5Uz7uPt7a7Zaj7HqMYWFzsIj5uV92WleFcT28RnjcUUXO8KtE4jHt1o+sHwmhU6 9ntA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to; bh=VsFeMplfd2mLri5rvahdtG5Udoy8MtxqdbkpV3WFLPc=; b=MrDTK6hm5bv66rm9AKZf2CoVEPJ0O108mr8F1pZ+2VBTYj3HQLSx8DC1EM3LaTY+lf SCEGackEvveDQxFhqhmstZ8sD2ljigZZ1Gt3rQ8NYc+jb16zN2ZLxDQX6/M1iJQKohfU wzzORScwVkS0dY/4yqV0tCbKAgdicP/Y3s7EAZEb+lxFjJiQe4ZezpWZh7Y2Rut3Knq0 5WamOMqSx6QJqgCrhdng8AaXWxqRUtWb+TQD6LfINieGg198eIdBXr/yinjELAA0bwOJ 4eBDgn6IOGJYsQVD1hhlkSMhQ66/DrHSBsR1q/2g9ecaStNiiSO2vr3iKzMNj355E8Jz k/DQ== X-Gm-Message-State: AOAM533D8ctktkN0VvIuwT9yF3U+UuJO2soHvFhq4zUp0JTfX88nJvaX TAxmSKcmYMUHbfwClDzDhej104ZGDhY= X-Google-Smtp-Source: ABdhPJxJtxHY8Cm7fsIhptd019tC++81WsdOt3P+iwuyTdTNCuy/bXgqCagXKLjP3piqpYmZZRVQKw== X-Received: by 2002:a5d:68c9:: with SMTP id p9mr56877412wrw.139.1609272236918; Tue, 29 Dec 2020 12:03:56 -0800 (PST) Received: from brick (cpc159423-cmbg20-2-0-cust338.5-4.cable.virginm.net. [86.7.147.83]) by smtp.gmail.com with ESMTPSA id h5sm63275436wrp.56.2020.12.29.12.03.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Dec 2020 12:03:56 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Tue, 29 Dec 2020 20:03:54 +0000 From: Edward Tomasz Napierala To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Subject: Re: git: 89e3d5671ba1 - main - bsnmpclient(3): make it thread-safe Message-ID: Mail-Followup-To: Jessica Clarke , "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" References: <202012291500.0BTF0vGw034594@gitrepo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 4D55321fwtz3LK6 X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: dev-commits-src-main@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "Commit messages for the main branch of the src repository." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Dec 2020 20:03:58 -0000 On 1229T1511, Jessica Clarke wrote: [..] > Is there really a documented requirement for everything to be called > from the same thread? I can see consumers of the library that already > use proper locking breaking because of this. I'm not aware of such requirement being documented; guess I was bit too much fixated on the one use case this patch fixes. Given that harti@ mentioned he's planning to get rid of global data, and other problems pointed out here, I think it's best to just revert it.