From owner-cvs-src@FreeBSD.ORG Thu Sep 18 19:49:47 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.ORG Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8E98A106566B; Thu, 18 Sep 2008 19:49:47 +0000 (UTC) (envelope-from sos@FreeBSD.ORG) Received: from deepcore.dk (adsl.deepcore.dk [87.63.29.106]) by mx1.freebsd.org (Postfix) with ESMTP id D3B998FC24; Thu, 18 Sep 2008 19:49:46 +0000 (UTC) (envelope-from sos@FreeBSD.ORG) Received: from [192.168.0.138] ([192.168.0.138]) by deepcore.dk (8.14.3/8.14.2) with ESMTP id m8IJRwAg091354; Thu, 18 Sep 2008 21:27:58 +0200 (CEST) (envelope-from sos@FreeBSD.ORG) Message-Id: <45929AC0-E324-4CE5-962B-DEDFA9BD173C@FreeBSD.ORG> From: =?ISO-8859-1?Q?S=F8ren_Schmidt?= To: John Baldwin In-Reply-To: <200809181024.35437.jhb@freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed; delsp=yes Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Apple Message framework v926) Date: Thu, 18 Sep 2008 21:27:58 +0200 References: <200809181212.m8ICCmgw043093@repoman.freebsd.org> <200809181024.35437.jhb@freebsd.org> X-Mailer: Apple Mail (2.926) X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.0 (deepcore.dk [217.20.59.72]); Thu, 18 Sep 2008 21:27:58 +0200 (CEST) Cc: cvs-src@FreeBSD.ORG, src-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 18 Sep 2008 19:49:47 -0000 On 18Sep, 2008, at 16:24 , John Baldwin wrote: > On Thursday 18 September 2008 08:12:34 am SXren Schmidt wrote: >> sos 2008-09-18 12:12:34 UTC >> >> FreeBSD src repository >> >> Modified files: >> sys/dev/ata ata-chipset.c ata-pci.c ata-pci.h >> Log: >> SVN rev 183141 on 2008-09-18 12:12:34Z by sos >> >> Cleanup the AHCI code a bit. >> Add suspend/resume for AHCI, general methods added. >> >> Inspired by: Andrey V. Elsukov > > Oo! I have suspend/resume for ICH then that fix my laptop at > www.freebsd.org/~jhb/patches/ata_resume.patch. These count on being =20= > able to > have some controller-specific data in the softc for holding state =20 > across > suspend/resume. However, I'm glad to see you are now ok with having =20= > real > suspend/resume methods. Sure, but this needs more work in the sense that the chipinit/allocate =20= code needs to be sorted out so resume can get the chipset back into =20 shape without reallocating resources. If this is done properly it can =20= be generically used on all chipsets wihtout the need for suspend/=20 resume code for each and every chipset. These new hook should be used =20= for just that, not for kludging in all kinds of crap everywhere, its =20 *not* needed in any but a few special cases. Anyhow as is evident I dont have much time currently and I see that =20 things are getting somewhat out of control, so my opinion is just =20 that :) -S=F8ren -S=F8ren > > > --=20 > John Baldwin > -S=F8ren