From owner-svn-src-all@freebsd.org  Sat Dec  5 19:00:34 2015
Return-Path: <owner-svn-src-all@freebsd.org>
Delivered-To: svn-src-all@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 3DC5CA422FF;
 Sat,  5 Dec 2015 19:00:34 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 290811233;
 Sat,  5 Dec 2015 19:00:34 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [IPv6:::1])
 by freefall.freebsd.org (Postfix) with ESMTP id 246E41573;
 Sat,  5 Dec 2015 19:00:34 +0000 (UTC)
 (envelope-from bdrewery@FreeBSD.org)
Received: from mail.xzibition.com (localhost [172.31.3.2])
 by mail.xzibition.com (Postfix) with ESMTP id E516B17AA9;
 Sat,  5 Dec 2015 19:00:33 +0000 (UTC)
X-Virus-Scanned: amavisd-new at mail.xzibition.com
Received: from mail.xzibition.com ([172.31.3.2])
 by mail.xzibition.com (mail.xzibition.com [172.31.3.2]) (amavisd-new,
 port 10026)
 with LMTP id Fs7jxhZzQoAH; Sat,  5 Dec 2015 19:00:31 +0000 (UTC)
Subject: Re: svn commit: r291864 - head/lib/libc/tests/ssp
DKIM-Filter: OpenDKIM Filter v2.9.2 mail.xzibition.com 61B5317AA2
To: src-committers@freebsd.org, svn-src-all@freebsd.org,
 svn-src-head@freebsd.org
References: <201512051856.tB5IuMsg067499@repo.freebsd.org>
From: Bryan Drewery <bdrewery@FreeBSD.org>
Organization: FreeBSD
Message-ID: <5663344E.2050308@FreeBSD.org>
Date: Sat, 5 Dec 2015 11:00:30 -0800
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:38.0)
 Gecko/20100101 Thunderbird/38.4.0
MIME-Version: 1.0
In-Reply-To: <201512051856.tB5IuMsg067499@repo.freebsd.org>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
 user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>,
 <mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 05 Dec 2015 19:00:34 -0000

On 12/5/15 10:56 AM, Bryan Drewery wrote:
> Author: bdrewery
> Date: Sat Dec  5 18:56:21 2015
> New Revision: 291864
> URL: https://svnweb.freebsd.org/changeset/base/291864
> 
> Log:
>   Fix regression in r291738: This really wants -lssp.
>   
>   The normal LIBADD is ssp_nonshared.  This also had a DPADD on LIBSSP which
>   does not actually exist, it is blank.
>   
>   Sponsored by:	EMC / Isilon Storage Division
> 
> Modified:
>   head/lib/libc/tests/ssp/Makefile
> 
> Modified: head/lib/libc/tests/ssp/Makefile
> ==============================================================================
> --- head/lib/libc/tests/ssp/Makefile	Sat Dec  5 17:40:11 2015	(r291863)
> +++ head/lib/libc/tests/ssp/Makefile	Sat Dec  5 18:56:21 2015	(r291864)
> @@ -10,7 +10,7 @@ CFLAGS.h_raw+=	-fstack-protector-all -Ws
>  CFLAGS.h_raw+=	-fsanitize=bounds
>  .elif ${COMPILER_TYPE} == "gcc"
>  CFLAGS.h_raw+=	--param ssp-buffer-size=1
> -LIBADD+=	ssp
> +LDADD+=	-lssp
>  .endif
>  
>  NETBSD_ATF_TESTS_SH=	ssp_test
> 

This may actually need to be LIBADD+=ssp_nonshared. I am just too busy
at the moment to look into it properly.

-- 
Regards,
Bryan Drewery