From owner-p4-projects@FreeBSD.ORG  Mon Jun 28 12:20:28 2004
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 4226D16A62F; Mon, 28 Jun 2004 12:20:27 +0000 (GMT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 041D816A628; Mon, 28 Jun 2004 12:20:27 +0000 (GMT)
Received: from exchhz01.viatech.com.cn (ip-40-162-97-218.anlai.com
	[218.97.162.40])	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 7EFD243D49; Mon, 28 Jun 2004 12:20:08 +0000 (GMT)
	(envelope-from davidxu@freebsd.org)
Received: from freebsd.org (DAVIDWNT [10.4.1.99]) by exchhz01.viatech.com.cn
	with SMTP (Microsoft Exchange Internet Mail Service Version 5.5.2650.21)
	id NVXA6KMS; Mon, 28 Jun 2004 14:24:24 +0800
Message-ID: <40DFBA3C.7040806@freebsd.org>
Date: Mon, 28 Jun 2004 14:27:08 +0800
From: David Xu <davidxu@freebsd.org>
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
	rv:1.5b) Gecko/20030723 Thunderbird/0.1
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Marcel Moolenaar <marcel@FreeBSD.org>
References: <200406280413.i5S4DS0D033867@repoman.freebsd.org>
In-Reply-To: <200406280413.i5S4DS0D033867@repoman.freebsd.org>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
cc: Daniel Eischen <deischen@FreeBSD.org>
cc: Perforce Change Reviews <perforce@freebsd.org>
Subject: Re: PERFORCE change 55970 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 28 Jun 2004 12:20:28 -0000


OK, I am glad to see you are working on libthread_db, but
I have already a libthread_db tree in ksedbg branch.
I am current making libthread_db.so in two levels:
the first level is a umbrella, the second level is a driver,
every thread library will have a driver, I found you were trying
to mix three thread libraries code into in same functions,
things like following code looks strange for me, how can you
include three different thr_pirvate.h in same .c, and compile
them ?

+td_ta_map_lwp2thr(const td_thragent_t *ta, lwpid_t lwp, td_thrhandle_t *th)
 >  {
 > -	return (TD_OK);
 > +	ps_err_e err;
 > +
 > +	th->th_ta = ta;
 > +
 > +	switch (ta->ta_lib) {
 > +	case PTHREAD_LIBC_R:
 > +		err = ps_pread(ta->ta_ph, ta->ta.libc_r.thread_run,
 > +		    &th->th_thread, sizeof(psaddr_t));
 > +		return (err == PS_OK) ? TD_OK : TD_ERR;
 > +	case PTHREAD_LIBKSE:
 > +		lwp = 0;
 > +		return (TD_NOTHR);
 > +	case PTHREAD_LIBTHR:
 > +		return (TD_NOTHR);
 > +	}
 > +	return (TD_ERR);
 >  }


Marcel Moolenaar wrote:
> http://perforce.freebsd.org/chv.cgi?CH=55970
> 
> Change 55970 by marcel@marcel_nfs on 2004/06/28 04:12:48
> 
> 	Submit the result of me fucking around a bit:
> 	o  Add td_ta_delete()
> 	o  Make this WARNS 4 clean. This basicly means adding __unused
> 	   to most of the argument of the functions I haven't implemented
> 	   yet.
> 	o  Detect libc_r and libthr. I don't worry about libkse, because
> 	   davidxu@ is playing with that. We probably need to combine our
> 	   efforts...
> 	o  Implement some of the functions that GDB already needs. In
> 	   particular I see td_ta_thr_iter() play a pivoting role...
> 
> Affected files ...