Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 15 Jun 2015 16:49:00 +0300
From:      Andriy Gapon <avg@FreeBSD.org>
To:        Ed Maste <emaste@FreeBSD.org>
Cc:        "src-committers@freebsd.org" <src-committers@FreeBSD.org>, "svn-src-all@freebsd.org" <svn-src-all@FreeBSD.org>, svn-src-vendor@FreeBSD.org
Subject:   Re: svn commit: r284412 - in vendor-sys/illumos/dist/uts/common/fs/zfs: . sys
Message-ID:  <557ED7CC.7030002@FreeBSD.org>
In-Reply-To: <CAPyFy2DOPg6KTLYv5MSRNuUHYL8FX=PrEdJzKC%2BY2nLVSU%2BU=g@mail.gmail.com>
References:  <201506151250.t5FCoifP019075@svn.freebsd.org> <CAPyFy2Cuo7mULXN6=9irUUSf3nXsqX8jjnTCYD4qzBMXPPO5Eg@mail.gmail.com> <557ECD22.8090402@FreeBSD.org> <CAPyFy2DOPg6KTLYv5MSRNuUHYL8FX=PrEdJzKC%2BY2nLVSU%2BU=g@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 15/06/2015 16:42, Ed Maste wrote:
> On 15 June 2015 at 09:03, Andriy Gapon <avg@freebsd.org> wrote:
>>
>> I guess I could extend my script to expand 5911 to
>> https://www.illumos.org/issues/5911
> 
> Yeah, I think that would be useful -- although it's probably too long
> to go in the first line, then.
> 
> I guess the problem is that the upstream Illumos commits follow a
> certain convention, and that meaning/context is lost when they come
> into FreeBSD. Linking to the original issue should take care of that.
> 

Yes, indeed.  Regular ZFS/FreeBSD hackers are aware of the conventions and
places to look, but most of committers do not necessarily know of them.

So, this is the format that I will try use (using this commit as an example):
========================================
5911 ZFS "hangs" while deleting file

Reviewed by: Bayard Bell <buffer.g.overflow@gmail.com>
Reviewed by: Alek Pinchuk <alek@nexenta.com>
Reviewed by: Simon Klinkert <simon.klinkert@gmail.com>
Reviewed by: Dan McDonald <danmcd@omniti.com>
Approved by: Richard Lowe <richlowe@richlowe.net>
Author: Matthew Ahrens <mahrens@delphix.com>

illumos/illumos-gate@46e1baa6cf6d5432f5fd231bb588df8f9570c858
https://www.illumos.org/issues/5911
========================================

-- 
Andriy Gapon



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?557ED7CC.7030002>