From owner-freebsd-stable@FreeBSD.ORG Thu Nov 14 16:44:25 2013 Return-Path: Delivered-To: freebsd-stable@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 27B5516E for ; Thu, 14 Nov 2013 16:44:25 +0000 (UTC) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id 5A0B929E6 for ; Thu, 14 Nov 2013 16:44:23 +0000 (UTC) Received: from porto.starpoint.kiev.ua (porto-e.starpoint.kiev.ua [212.40.38.100]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id SAA12729; Thu, 14 Nov 2013 18:44:13 +0200 (EET) (envelope-from avg@FreeBSD.org) Received: from localhost ([127.0.0.1]) by porto.starpoint.kiev.ua with esmtp (Exim 4.34 (FreeBSD)) id 1Vh01d-000OT0-HX; Thu, 14 Nov 2013 18:44:13 +0200 Message-ID: <5284FDA5.8080006@FreeBSD.org> Date: Thu, 14 Nov 2013 18:43:17 +0200 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:24.0) Gecko/20100101 Thunderbird/24.1.0 MIME-Version: 1.0 To: Steven Hartland , hartzell@alerce.com, freebsd-stable@FreeBSD.org Subject: Re: Help with filing a [maybe] ZFS/mmap bug. References: <20967.760.95825.310085@gargle.gargle.HOWL><51E80B30.1090004@FreeBSD.org><20968.10645.880772.30501@gargle.gargle.HOWL><520202E5.30300@FreeBSD.org><20994.55913.93606.436124@gargle.gargle.HOWL> <21111.12085.958991.356982@gargle.gargle.HOWL> <4EB902F80CE84DD2BF36C85EF4CE8EF8@multiplay.co.uk> <5284B8A5.8040604@FreeBSD.org> In-Reply-To: X-Enigmail-Version: 1.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.16 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 14 Nov 2013 16:44:25 -0000 on 14/11/2013 17:55 Steven Hartland said the following: > ----- Original Message ----- From: "Andriy Gapon" > >>>> I was able recreate the problem on a 10-BETA-something-or-other >>>> recently (I'd only been using 9 up until then). Andriy's patches >>>> didn't make a difference. I haven't heard anything since reporting >>>> back to him. >>> >>> I've pretty much confirmed mmap support is causing the corruption when >>> running rrdcached as since rebuilding with mmap disabled I've had no >>> further corruption. >> >> Well, this is not a _proof_, of course... > > Proof that mmap is causing the corruption, not that ZFS mmap support > is the point at fault, as the code in rrdtool takes a different path > so could still be an application error, but without mmap enabled I've > seen zero corruption so... On some days I wore a green t-shirt and sometimes it rained. On other days I wore a red t-shirt and it never rained (so far, of course). Is this a _proof_ that my red t-shirt acts as a rain repellant? :-) The correlation I won't deny. >>> @George when you got corruption what did the files look like? I ask as >>> here I see lots of zeros as through the file size was correct but pretty >>> much blanked. >> >> Steve, could you please provide a little bit more of description of the >> corruption that you got. Lengths of those zeroed regions, their offsets (modulo >> page size). >> Anything that could establish a pattern (if any exists). > > They all seem to be corrupted to the same file which when dumped using > hexdump -C results in: > 00000000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| > * > 00001000 00 00 00 00 00 00 f8 ff 00 00 00 00 00 00 f8 ff |................| > * > 000a8000 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 |................| > * > 000af000 00 00 00 00 00 00 f8 ff 00 00 00 00 00 00 f8 ff |................| > * > 00113de0 It seems like the file has lots of page-sized zeroed regions in it. I am not familiar with the rrd format... Could this result from some natural causes (like absence of data)? ALthough, the first page being all zeros is quite suspicious. In either case, it looks very different from what George reported. -- Andriy Gapon