From owner-svn-ports-all@freebsd.org Fri Apr 13 15:01:45 2018 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5C7ECF8F452; Fri, 13 Apr 2018 15:01:45 +0000 (UTC) (envelope-from joneum@FreeBSD.org) Received: from toco-domains.de (mail.toco-domains.de [176.9.39.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id E8067756A0; Fri, 13 Apr 2018 15:01:44 +0000 (UTC) (envelope-from joneum@FreeBSD.org) Received: from phantomias.home.jochen-neumeister.de (p5B0FDDA2.dip0.t-ipconnect.de [91.15.221.162]) by toco-domains.de (Postfix) with ESMTPA id 7ECC11AAF067; Fri, 13 Apr 2018 17:01:35 +0200 (CEST) Subject: Re: svn commit: r467193 - in head/www/gitlab: . files To: Joseph Mingrone , Matthias Fechner Cc: Sunpoet Po-Chuan Hsieh , Torsten Zuehlsdorff , ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201804121833.w3CIXtgW077267@repo.freebsd.org> <431aaec9-51c2-c0c9-7a1f-2f29f79edb5d@fechner.net> <20180413100736.GA32041@FreeBSD.org> <86o9inrzzk.fsf@phe.ftfl.ca> From: Jochen Neumeister Message-ID: Date: Fri, 13 Apr 2018 17:01:28 +0200 MIME-Version: 1.0 In-Reply-To: <86o9inrzzk.fsf@phe.ftfl.ca> Content-Language: de-DE Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.25 X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Apr 2018 15:01:45 -0000 On 13.04.2018 15:35, Joseph Mingrone wrote: > Matthias Fechner writes: >> Dear sunpoet, >> Am 12.04.2018 um 20:33 schrieb Sunpoet Po-Chuan Hsieh: >>> Log: >>> Fix Gemfile for rubygem-default_value_for 3.1.0 update >>> - Bump PORTREVISION for package change >>> Modified: >>> head/www/gitlab/Makefile >>> head/www/gitlab/files/patch-Gemfile >> I really enjoy your work and it is totally fine for me, if you upgrade a >> gem that you copy the old one and make sure that gitlab uses the old. >> (like you did with r467106, thanks a lot for this!) >> But please do not start to patch the Gemfile! >> This will break gitlab. Have you tested gitlab with this modification? >> (for sure not, I reported exactly that version of default_value_for >> upstream and they rolled back the change as it broke gitlab, they broke >> 3.0.4 and rolled back the modification with 3.0.5, now you changed >> gitlab to use the version that for sure will not work!) >> Please revert this modification and ask me (the maintainer) before you >> start to modify the port I maintain. >> Thanks a lot that you understand this. >> Gruß >> Matthias > I relate. Sunpoet, I also appreciate your work, but this type of > breakage can be frustrating. We need to figure out a solution. > +1 Unfortunately sunpoet does not always react when it draws attention to errors. Funny: he complained about the mistake myself last year. It needs a solution to better respect the work of others. joneum