From owner-cvs-all@FreeBSD.ORG Tue Jun 21 06:37:18 2005 Return-Path: X-Original-To: cvs-all@FreeBSD.org Delivered-To: cvs-all@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 7C7C816A41C; Tue, 21 Jun 2005 06:37:18 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from smtp-1.dlr.de (smtp-1.dlr.de [195.37.61.185]) by mx1.FreeBSD.org (Postfix) with ESMTP id 0976643D49; Tue, 21 Jun 2005 06:37:17 +0000 (GMT) (envelope-from Hartmut.Brandt@dlr.de) Received: from beagle.kn.op.dlr.de ([129.247.173.6]) by smtp-1.dlr.de over TLS secured channel with Microsoft SMTPSVC(6.0.3790.211); Tue, 21 Jun 2005 08:37:16 +0200 Date: Tue, 21 Jun 2005 08:37:11 +0200 (CEST) From: Harti Brandt X-X-Sender: brandt_h@beagle.kn.op.dlr.de To: Garance A Drosehn In-Reply-To: Message-ID: <20050621083525.H20063@beagle.kn.op.dlr.de> References: <200506200314.j5K3EUtt089472@repoman.freebsd.org> <20050620094103.GB54301@cat.robbins.dropbear.id.au> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-OriginalArrivalTime: 21 Jun 2005 06:37:16.0564 (UTC) FILETIME=[AA78C540:01C5762B] Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org, Tim Robbins Subject: Re: cvs commit: src/usr.bin/env env.c X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Harti Brandt List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2005 06:37:18 -0000 On Mon, 20 Jun 2005, Garance A Drosehn wrote: GAD>At 7:41 PM +1000 6/20/05, Tim Robbins wrote: GAD>> On Mon, Jun 20, 2005, Garance A Drosehn wrote: GAD>> > gad 2005-06-20 03:14:29 UTC GAD>> > GAD>> > FreeBSD src repository GAD>> > GAD>> > Modified files: GAD>> > usr.bin/env env.c GAD>> > Log: GAD>> > If the `utility' specified starts with a '/' character, then GAD>> > execute it without checking it for an equals-sign. If it GAD>> > starts with a slash, then it cannot be a request to set the GAD>> > value of a valid environment variable. GAD>> GAD>> This is not strictly correct: GAD>> GAD>> The value of an environment variable is a string of characters. GAD> ... GAD>> These strings have the form name=value; names shall not contain GAD>> the character '='. For values to be portable across systems GAD>> conforming to IEEE Std 1003.1-2001, the value shall be composed GAD>> of characters from the portable character set (except NUL and as GAD>> indicated below). GAD> GAD>Ah. I jumped to the wrong conclusion based on the description of GAD>setting environment variables in the man page for 'sh'. Neither GAD>sh nor bash allow you to set /SOMEVAR=YES. setenv in csh seems to GAD>let you set a value, but then it complains 'Illegal variable name' GAD>if you try to reference it... GAD> [snip] GAD>But I wouldn't mind to undo the '/' check, if people think that's GAD>a problem. I only came up with that idea just before I was ready GAD>to commit, while I was stealing lines from the 'sh' man page... Yes, please undo. harti