From nobody Tue Aug 19 17:42:20 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4c5xjx63qVz65K1d; Tue, 19 Aug 2025 17:42:29 +0000 (UTC) (envelope-from markjdb@gmail.com) Received: from mail-qt1-x82b.google.com (mail-qt1-x82b.google.com [IPv6:2607:f8b0:4864:20::82b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4c5xjx40Fmz444B; Tue, 19 Aug 2025 17:42:29 +0000 (UTC) (envelope-from markjdb@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-qt1-x82b.google.com with SMTP id d75a77b69052e-4b109919a09so68821911cf.0; Tue, 19 Aug 2025 10:42:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1755625343; x=1756230143; darn=freebsd.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=vcDD+Nc+rTNCF9PXZYbALVeco2WIkoiOJTiOcMnQ+Wk=; b=X5SU7D0LnWfuBE9RxpOS5uxZOvZZ6dcO2bXyJ3MURsMbe7uRZql/IyeHosO7Qzszh9 +iF3PtkQ3xiowQvwLawhz5GHvCUTzwO2W6L/inMyncEsXmFENei4sVWaPwqZxGrSptZY N6bguFPs5KDQlazH0SGozpUCgHd0qPnWll5aY6JOklTZL+gE88l6Os2jq3oLOUd/AmQf hCFIMgxIq1YcZGpxphQ7Y2svXsll7GCUFAwvRadbQNObuhviXjRbOTlLibrTRiQdl0En NkJN79ZX9pQdXVVOWeqQY7ByZ4l2V/2Tp4s50ZLbTDq76tNn11eLraoswxNqR4doI4vE wfNA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755625343; x=1756230143; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=vcDD+Nc+rTNCF9PXZYbALVeco2WIkoiOJTiOcMnQ+Wk=; b=FrNsRTNInq+zm266hSjN/xQ+MdLLEU6id3ROLc6tGwK75yBWGMD2eYQAQEcAFafGMh UZcFBacWZT+6Pb0S0aiTY+NUB6P3bOLLMruiEvL3UxXLcyh4FZCXt92vs5GPajUZmk7T TK8a++RYOjqkHxsRWctJ1uuwU9h1yCZocVRwiD5dx9mZdbZlxDmbU37HXTKhWHyV5hCk bJC3knJmX0P0XVZ981zmDntZJ+CGzG9DDAOCOM74y1hlWgonq1Rv7JSadYBZ5xoQpCON Cs+Y44h8XpGi06XidEdnOJ0kEYBDFXEZwnFrsvpyGCv0xHxZOZY+ODcgJsMgMepwFuuQ 9YMw== X-Forwarded-Encrypted: i=1; AJvYcCUCKcXMyEJAwm27p+KLwGIzkVilXd/49YwTO7Moz1LGNdd4Y0XVEVBb2WcIetMcqmrjotc1Y9SN5VIvBr4dT5OER954@freebsd.org, AJvYcCVeQxvllXgeHYRpem+FL90ezq4xkMSWEu2PhmQUhRDipuDO75cXBrr3le5dQBzPEDbGvZ+XxP0LIrcGQ+zD8+ZbYOQyAw8=@freebsd.org X-Gm-Message-State: AOJu0YyPPU9mFtH4YOroxsPZam/K0idbvupcdk0fbcH9W46X6Ifet5wK HgFBmsQl33nOC7i5vFS7LYqLoltNnHjhpFBOfUKF5VF/nEUnSQEHvDrRxwnPIzOa X-Gm-Gg: ASbGncsPCApcx/T9Wo56RUrdCmChciq5DVa4vVeFPUfk7loIXr/TwTwdg1StCw8aXhv YVTQkYIFemZiKqLV/tQ9ri49/cNZ7YnNxKwFDqWHpPDSETeGzIp66Itrtnjz5Xo2etjT5K7tER1 DErrWVq2XOixZIfRU6pD+H7k0OYh7HIOqZgM0GN5sCSMi0iQ5tX+Tve6qcyU35/T6quO+I8KHbM ngvQv6+oEaTzEs584s6wheMkpMYQFF/DENPf7cDiHT1XTYQ9DHsnMjFVoHQacesp5gCiRskzZD4 u0js91/iD6Aali4kU66nJrp4gFLvx2t2VQb4yVmdU26m0r+AGRRbwuB4OdyDy3KTFkQAk6dZQrL Mk3erhVOm5m0AynbOzdiX6hIy4Z5U4vS2DC7J X-Google-Smtp-Source: AGHT+IH/Oi84xEMiFBec8dDQs3ZYW5zIIiKiz5FfITKpjkWhLHGdmc+vjO7zdBijkpNWyhVoeanM5g== X-Received: by 2002:ac8:5941:0:b0:4b0:7581:4dbf with SMTP id d75a77b69052e-4b286cf51eamr39074651cf.18.1755625343335; Tue, 19 Aug 2025 10:42:23 -0700 (PDT) Received: from nuc (192-0-220-237.cpe.teksavvy.com. [192.0.220.237]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4b27e61a597sm24417431cf.38.2025.08.19.10.42.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Aug 2025 10:42:22 -0700 (PDT) Date: Tue, 19 Aug 2025 13:42:20 -0400 From: Mark Johnston To: Dima Panov Cc: src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 5105e1ebecc7 - main - krb5: Fix the installed compile_et Message-ID: References: <202508191320.57JDKkFi035855@gitrepo.freebsd.org> <80b17387-74d5-40b0-80e5-ca756bed0649@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <80b17387-74d5-40b0-80e5-ca756bed0649@FreeBSD.org> X-Spamd-Bar: ---- X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Rspamd-Queue-Id: 4c5xjx40Fmz444B On Tue, Aug 19, 2025 at 08:33:49PM +0300, Dima Panov wrote: > Hello! > > On 19.08.2025 16:20, Mark Johnston wrote: > > diff --git a/krb5/Makefile.inc b/krb5/Makefile.inc > > index cd54f7a0eff6..6db4e8d964aa 100644 > > --- a/krb5/Makefile.inc > > +++ b/krb5/Makefile.inc > > @@ -14,7 +14,7 @@ KRB5_VERSION= 1.22-final > > # MIT KRB5 uses KRB5_DIR. Heimdal uses KRB5DIR. > > KRB5_SRCTOP= ${SRCTOP}/krb5 > > KRB5_DIR= ${SRCTOP}/crypto/krb5/src > > -KRB5_ETDIR?= ${DESTDIR}/usr/share/et > > +KRB5_ETDIR?= /usr/share/et > > KRB5_SRCLIBDIR= ${KRB5_DIR}/lib > > KRB5_OBJTOP= ${OBJTOP}/krb5 > > diff --git a/krb5/util/et/Makefile b/krb5/util/et/Makefile > > index 6eceb253c3b0..0d474efa1e8e 100644 > > > What the reason to omit ${DESTDIR} here? > It will be always install by global path instead of requested destination root. This is consistent with how we handle other utilities. For instance, man(1) searches /usr/share/man, not ${DESTDIR}/usr/share/man, executables are started by /libexec/ld-elf.so.1, not ${DESTDIR}/libexec/ld-elf.so.1, etc..