From owner-cvs-src Wed Mar 19 22:13:22 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 37AFC37B404; Wed, 19 Mar 2003 22:13:19 -0800 (PST) Received: from nagual.pp.ru (pobrecita.freebsd.ru [194.87.13.42]) by mx1.FreeBSD.org (Postfix) with ESMTP id D9CD343F75; Wed, 19 Mar 2003 22:13:17 -0800 (PST) (envelope-from ache@pobrecita.freebsd.ru) Received: from pobrecita.freebsd.ru (ache@localhost [127.0.0.1]) by nagual.pp.ru (8.12.8/8.12.8) with ESMTP id h2K6DGjx049052; Thu, 20 Mar 2003 09:13:16 +0300 (MSK) (envelope-from ache@pobrecita.freebsd.ru) Received: (from ache@localhost) by pobrecita.freebsd.ru (8.12.8/8.12.6/Submit) id h2K6DGpl049051; Thu, 20 Mar 2003 09:13:16 +0300 (MSK) (envelope-from ache) Date: Thu, 20 Mar 2003 09:13:16 +0300 From: "Andrey A. Chernov" To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/contrib/gdtoa gdtoaimp.h Message-ID: <20030320061316.GA48935@nagual.pp.ru> References: <200303192025.h2JKPjNr000550@repoman.freebsd.org> <20030320050712.GA48184@nagual.pp.ru> <20030320054502.GA4308@HAL9000.homeunix.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20030320054502.GA4308@HAL9000.homeunix.com> User-Agent: Mutt/1.5.1i Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Mar 19, 2003 at 21:45:02 -0800, David Schultz wrote: > Do you see anything else I should bug the vendor about while I'm at > it? So far I notice one thing only: char decimalpoint = *localeconv()->decimal_point; ... and then decimalpoint used everywhere in the code. But localeconv() can return "" for any value which is legally not in the current locale. decimalpoint becomes '\0' in that case which cause unwanted effects. So there always must be added fallback code something like: if (decimalpoint == '\0') decimalpoint = '.'; in all places after localeconv() called. > > The next thing is style: why > > #include "locale.h" > > instead of > > #include ? > > With one exception, the author uses that convention consistently. I don't think so - I saw , in the author's code. It may affect cross-platform building when standard includes moved to other place and gcc instructed to find them there. -- Andrey A. Chernov http://ache.pp.ru/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message