From owner-svn-src-head@FreeBSD.ORG Mon Aug 18 20:06:03 2014 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D3F14D81; Mon, 18 Aug 2014 20:06:02 +0000 (UTC) Received: from mail-qc0-x235.google.com (mail-qc0-x235.google.com [IPv6:2607:f8b0:400d:c01::235]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4AC2C304B; Mon, 18 Aug 2014 20:06:02 +0000 (UTC) Received: by mail-qc0-f181.google.com with SMTP id x13so5312952qcv.40 for ; Mon, 18 Aug 2014 13:06:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:in-reply-to:references :mime-version:content-type; bh=1R7B/aJ8tdPu9MHEqZe2dQafgVUJylt2hpSNgVzK4Aw=; b=IXQIYA0BKZP9Ulot7bqv+Oyw6/kI4IhFyvWCMz1uo5jAfXqi/t/XQvjRdNa03liMwN +DhtXVjCkltUQk0oU81owbZMQ7E2WD+7WjErdJ3h9pLAIoF8B80jQB2FMYOZltUzGCqa M6FGo0xIJJhI5OYqE6oOz4N7DYUra+lrm8CcdzjdxyC0xOiEU7/dhkIKwiIn5JsrMTta rXPVLbJy8DfWmVDrkktOAJaeYKKUSwKKoQ5a2AIo+lJbGtVtB58ZNpGtG67RcDkLAUpe vLN/H6RFiATQU+w+mjxciVfVQPZAFBkYQpByG2HkupfpDFnlBJx1x1rkist/tKBjARUi sWmg== X-Received: by 10.224.51.197 with SMTP id e5mr7529536qag.48.1408392360787; Mon, 18 Aug 2014 13:06:00 -0700 (PDT) Received: from kan ([2601:6:6780:7d0:226:18ff:fe00:232e]) by mx.google.com with ESMTPSA id j47sm19614368qge.46.2014.08.18.13.05.59 for (version=SSLv3 cipher=RC4-SHA bits=128/128); Mon, 18 Aug 2014 13:06:00 -0700 (PDT) Date: Mon, 18 Aug 2014 16:05:54 -0400 From: Alexander Kabaev To: Sergey Kandaurov Subject: Re: svn commit: r270149 - head/sys/geom Message-ID: <20140818160554.121e16e7@kan> In-Reply-To: References: <201408181927.s7IJRm9P048886@svn.freebsd.org> X-Mailer: Claws Mail 3.10.1 (GTK+ 2.24.22; amd64-portbld-freebsd11.0) MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; boundary="Sig_/wuk0Ge=9Fkog6ad5NJY+K_r"; protocol="application/pgp-signature" Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org, Scott Long X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Aug 2014 20:06:03 -0000 --Sig_/wuk0Ge=9Fkog6ad5NJY+K_r Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable On Mon, 18 Aug 2014 23:51:32 +0400 Sergey Kandaurov wrote: > On 18 August 2014 23:27, Scott Long wrote: > > Author: scottl > > Date: Mon Aug 18 19:27:47 2014 > > New Revision: 270149 > > URL: http://svnweb.freebsd.org/changeset/base/270149 > > > > Log: > > Deal explicitly with possible failures of make_dev_alias_p() in > > GEOM. > > > > Submitted by: Mariusz Zaborski > > MFC after: 3 days > > > > Modified: > > head/sys/geom/geom_dev.c > > > > Modified: head/sys/geom/geom_dev.c > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > > --- head/sys/geom/geom_dev.c Mon Aug 18 18:07:28 2014 > > (r270148) +++ head/sys/geom/geom_dev.c Mon Aug 18 19:27:47 > > 2014 (r270149) > [...] > > @@ -263,6 +264,7 @@ g_dev_taste(struct g_class *mp, struct g > > if (adev !=3D NULL) { > > adev->si_iosize_max =3D MAXPHYS; > > adev->si_drv2 =3D cp; > > + adev->si_flags |=3D SI_UNMAPPED; > > } > > > > g_dev_attrchanged(cp, "GEOM::physpath"); > > >=20 > This part looks unrelated. >=20 Commit says that it deals with consequences of make_dev_alias_p failing. Preventing trap happening on said failure seems to be pretty much related to the stated goal. --=20 Alexander Kabaev --Sig_/wuk0Ge=9Fkog6ad5NJY+K_r Content-Type: application/pgp-signature; name=signature.asc Content-Disposition: attachment; filename=signature.asc -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iD8DBQFT8lymQ6z1jMm+XZYRAnMZAJ9ayTNO8+RXLO1KqqHMIp4OrjYK1QCaAkDQ QRUR5Kf0e3gOfk/0qE81IJc= =WcCr -----END PGP SIGNATURE----- --Sig_/wuk0Ge=9Fkog6ad5NJY+K_r--