From owner-freebsd-rc@FreeBSD.ORG  Wed Nov  9 22:03:03 2005
Return-Path: <owner-freebsd-rc@FreeBSD.ORG>
X-Original-To: freebsd-rc@freebsd.org
Delivered-To: freebsd-rc@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1643016A41F;
	Wed,  9 Nov 2005 22:03:03 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (comp.chem.msu.su [158.250.32.97])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 4334843D45;
	Wed,  9 Nov 2005 22:03:02 +0000 (GMT)
	(envelope-from yar@comp.chem.msu.su)
Received: from comp.chem.msu.su (localhost [127.0.0.1])
	by comp.chem.msu.su (8.13.3/8.13.3) with ESMTP id jA9M2saK094480;
	Thu, 10 Nov 2005 01:02:54 +0300 (MSK)
	(envelope-from yar@comp.chem.msu.su)
Received: (from yar@localhost)
	by comp.chem.msu.su (8.13.3/8.13.3/Submit) id jA9M2okQ094476;
	Thu, 10 Nov 2005 01:02:50 +0300 (MSK) (envelope-from yar)
Date: Thu, 10 Nov 2005 01:02:50 +0300
From: Yar Tikhiy <yar@comp.chem.msu.su>
To: Maksim Yevmenkin <maksim.yevmenkin@savvis.net>
Message-ID: <20051109220250.GA91874@comp.chem.msu.su>
References: <436A6649.7000602@savvis.net>
	<20051103203217.GA30685@odin.ac.hmc.edu>
	<436BE02D.2020404@savvis.net>
	<20051107200040.GB29473@odin.ac.hmc.edu>
	<4370EAB4.8090000@savvis.net>
	<20051108201620.GD27091@odin.ac.hmc.edu>
	<43713B7D.7090405@savvis.net>
	<20051109063847.GB4605@comp.chem.msu.su>
	<43723223.3030802@savvis.net>
	<20051109191626.GG12837@odin.ac.hmc.edu>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20051109191626.GG12837@odin.ac.hmc.edu>
User-Agent: Mutt/1.5.9i
Cc: freebsd-bluetooth@freebsd.org, freebsd-rc@freebsd.org,
	Panagiotis Astithas <past@ebs.gr>
Subject: Re: [RFC] rc.d integration for the bluetooth subsystem
X-BeenThere: freebsd-rc@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "Discussion related to /etc/rc.d design and implementation."
	<freebsd-rc.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-rc>
List-Post: <mailto:freebsd-rc@freebsd.org>
List-Help: <mailto:freebsd-rc-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-rc>,
	<mailto:freebsd-rc-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 09 Nov 2005 22:03:03 -0000

On Wed, Nov 09, 2005 at 11:16:26AM -0800, Brooks Davis wrote:
> On Wed, Nov 09, 2005 at 09:30:11AM -0800, Maksim Yevmenkin wrote:
> > All,
> > 
> > >>i also removed offending { } in while loop stdin redirection. if this is 
> > >
> > >Thanks!  The handling of {} seems to be one of gray corners in sh(1)
> > >syntax if it works as in the initial version of your script.  Another
> > >one I've noticed is the case operator.  Your line was like this:
> > >
> > >	case $line in
> > >
> > >and it still worked for $line containing IFS chars.  sh(1) seems
> > >to put double quotes aroung the word passed to case implicitly.
> > >While such things may seem to make sh(1) coding a tad easier, I'm
> > >afraid they shouldn't be relied upon.
> > 
> > ok, do we agree that
> > 
> > http://people.freebsd.org/~emax/bluetooth-rc-4.diff.txt
> > 
> > looks fine? i have added double quotes around variables in case 
> > statements. any other comments, suggestions, objections?
> 
> Looks good to me.

To me, too (as good as it can look to a person who has never used
bluetooth :-)  I think it should be a good beginning.

-- 
Yar