Date: Sat, 17 May 2014 09:13:46 -0700 From: Nathan Whitehorn <nwhitehorn@freebsd.org> To: freebsd-sysinstall@freebsd.org Subject: Re: patch to bsdinstall to support BSD partitions Message-ID: <53778ABA.1010403@freebsd.org> In-Reply-To: <53778722.9000608@allanjude.com> References: <53778722.9000608@allanjude.com>
next in thread | previous in thread | raw e-mail | index | archive | help
This is not exactly a patch to bsdinstall to support plain BSD partitioning -- it has always done that. It is a patch to the ZFS module of bsdinstall. This kind of thing is one reason I was hoping the ZFS support could be integrated into the regular partition editor (which also knows how to set up EFI systems and such), to avoid this kind of duplication. I haven't had a chance to look at the submitted patches to do this, however. -Nathan On 05/17/14 08:58, Allan Jude wrote: > On some Lenovo machines, booting ZFS off MBR partitions does not work > > On the Lenovo X61s that we were able to test on at the BSDCan Hackers > Lounge, we were able to get them to boot properly using a BSD > partitioning scheme instead. > > > The attached patch makes the following changes: > > Add support for BSD partition type > > Moved the write of the MBR boot sector to the end of the process to > avoid it being nuked by the pedantic zpool labelclear commands > > Change the MBR code to not always create 2 zpools when using MBR. The > user only wants 2 pools (1 unencrypted to boot, and one encrypted for > data) in the case where they enable encryption. Due to the simplicity of > the code in previous versions of bsdinstall, two pools were used to > avoid a problem with the order of the creation of the partitions to > ensure that there was a partition at the front of the drive for the boot > code, and that the swap partition was the 2nd partition (BSD partition 'b') > > Some style cleanup to make the flow of the MBR section more > > fix an syntax error introduced in the previous patch where a newline was > not escaped > > Write the zfsboot code to the two different places require for MBR and > BSD. Write the larger section first because writing the first sector > first seems to make the BSD partition disappear and appear as an empty > MBR (No idea why this was happening, reproduced on two Lenovo laptops) > > Resolve variable reuse by renaming 'disksize' in second card to > 'usablesize' to avoid disksize being disksize less swap+boot size > > Sponsored By: ScaleEngine Inc. > > > _______________________________________________ > freebsd-sysinstall@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-sysinstall > To unsubscribe, send any mail to "freebsd-sysinstall-unsubscribe@freebsd.org"
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?53778ABA.1010403>