Date: Fri, 4 Jan 2019 14:40:47 +0100 From: Mathieu Arnold <mat@FreeBSD.org> To: Tobias Kortkamp <tobik@freebsd.org> Cc: Sean Bruno <sbruno@freebsd.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r489228 - in head/audio: clementine-player clementine-player/files libechonest Message-ID: <20190104134047.s7cvl4xl3shcsahs@ogg.in.absolight.net> In-Reply-To: <20190103232315.GA10712@urd.tobik.me> References: <201901032143.x03LhwZl017869@repo.freebsd.org> <20190103215421.GA13148@urd.tobik.me> <849c06ba-b298-2460-091b-0b3db52d8d16@freebsd.org> <20190103232315.GA10712@urd.tobik.me>
next in thread | previous in thread | raw e-mail | index | archive | help
--6qdpu6v4dqbqbefv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jan 04, 2019 at 12:23:15AM +0100, Tobias Kortkamp wrote: > On Thu, Jan 03, 2019 at 03:30:44PM -0700, Sean Bruno wrote: > >=20 > >=20 > > On 1/3/19 2:54 PM, Tobias Kortkamp wrote: > > >> +USE_QT=3D buildtools \ > > > Does clementine-player, a music player, really need qt5-buildtools > > > at runtime or should this be buildtools_build instead? > > >=20 > > >> + concurrent \ > > >> + core \ > > >> dbus \ > > >> gui \ > > >> imageformats \ > > >> - qmake_build \ > > >> linguist_build \ > > >> - moc_build \ > > >> network \ > > >> opengl \ > > >> - qtestlib \ > > >> - rcc_build \ > > >> + qmake_build \ > > >> + testlib \ > > > Same here. Does it really need qt5-testlib at runtime? > > >=20 > >=20 > > Probably not? > >=20 > > sean > >=20 >=20 > So I guess they are not needed at runtime. Will you change them > to build dependencies? >=20 > There is another more severe problem. The version goes backwards, > so users will never receive this update. >=20 > $ pkg version -t 1.3.1.g20190103 1.3.1.441_7 > < Yes, you should probably go back to using git describe --tags on the tag you are using and fill in the DISTVERSION/DISTVERSIONSUFFIX variables. --=20 Mathieu Arnold --6qdpu6v4dqbqbefv Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAlwvYl5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkinmBAAjBAF64vyTq0uyvu0n3gXXb5UHrTjjYy2q1QtmmLaJ+qSvcRpUz9Z9BME veyZ9gICcxZ9OFS+7b9K7y/trXzh6ciRCV3SkCMRd1RdiCgeBuivz7ppo+oD2P1d QowqB27FKc0JFtvX6QoBkPT2BFjxQ94wrRgqCoOevZXCQ6/RmoYxoAmYT8Z3C58h TZeaCj8KiQ2LT9QxAL6jHrwZbc7taMqbua3LXz/1JqwRdDWEI7PAG0saPziQl4PA 3Rgc0PeDX0Ry8Du2WZekUwSxYoECgkz3cUHAQ+FdyQRDTHkUKYpG1mFMX5bn72Eq dTkrOdnzCKa5F2VBtx2Ez9r2wBvxqWEZJwLLR4ShkFaE5HmfWvCIqnyKPDhoYey4 6SZb4gQiTYSkfjHE8zrGzT3Xe4Bgk6V/G2l8QUl9AF+cSBHHPg3d6eUCUrxDWLIL HyofSQIhSFtaGduQoX1+KZSV+ajtCtfOJEkmrKfD9k4O+fPKkFZc2ccTvJuKrF/A FHS5dBrHZzYi4xPGTmHnhcTwTkjH697nKDmjjRwquqVFOihQ7VmPdgE7IU/RrdEe iXZViH4f3haty4h/Dd6xAOeRVCOoEIJYpDYZldPX3MHphod1Xr89wYj0ZTeMvSm9 VVaId/2pWIpf+dwswIjXue0I1YrX2ot525HzMtx567V5C8Fl4Uk= =4+Xi -----END PGP SIGNATURE----- --6qdpu6v4dqbqbefv--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20190104134047.s7cvl4xl3shcsahs>