From owner-freebsd-arch@FreeBSD.ORG Thu Jan 17 23:48:41 2013 Return-Path: Delivered-To: freebsd-arch@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id CAFD1A96 for ; Thu, 17 Jan 2013 23:48:41 +0000 (UTC) (envelope-from stevek@juniper.net) Received: from exprod7og118.obsmtp.com (exprod7og118.obsmtp.com [64.18.2.8]) by mx1.freebsd.org (Postfix) with ESMTP id CE865DDB for ; Thu, 17 Jan 2013 23:48:40 +0000 (UTC) Received: from P-EMHUB03-HQ.jnpr.net ([66.129.224.36]) (using TLSv1) by exprod7ob118.postini.com ([64.18.6.12]) with SMTP ID DSNKUPiN2Iwj7fVy2suCJV/PsevGCClV6ROh@postini.com; Thu, 17 Jan 2013 15:48:41 PST Received: from stevek-ubuntu (172.25.4.212) by P-EMHUB03-HQ.jnpr.net (172.24.192.33) with Microsoft SMTP Server id 8.3.213.0; Thu, 17 Jan 2013 15:46:57 -0800 Date: Thu, 17 Jan 2013 18:46:54 -0500 From: Steve Kiernan To: Jason Evans Subject: Re: [JNPR] Proposal to add weak symbols for malloc, realloc, and free to libc Message-ID: <20130117184654.06f8e330@stevek-ubuntu> In-Reply-To: References: <20130117161311.4c15c7c4@stevek-ubuntu> Organization: Juniper Networks Inc. X-Mailer: Claws Mail 3.8.0 (GTK+ 2.24.10; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit Cc: freebsd-arch@freebsd.org X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2013 23:48:41 -0000 On Thu, 17 Jan 2013 15:42:19 -0800 Jason Evans wrote: > On Jan 17, 2013, at 1:13 PM, Steve Kiernan wrote: > > When libc was changed to use jemalloc, the weak symbols for malloc, realloc, and free ended up being removed. > > This makes it a bit difficult for an application to replace (or augment) the malloc implementation. > > > > This proposal is to add back the weak symbols similar to how they existed in libc prior to jemalloc introduction. > > > > See the following patch for the changes: > > http://people.freebsd.org/~marcel/Juniper/weak-malloc.diff > > > > I'm not sure if the the symbols are in the proper place in the Symbol.map file and would welcome comments. > > What about calloc(), posix_memalign(), and malloc_usable_size()? Similarly, I think the *allocm() functions in -current may need the same treatment. I think you are correct and those would probably be necessary, as well, yes. It looked like previously, calloc was not made weak because it was implemented in terms of malloc, but since that is not the case in jemalloc, it will need to be addressed. I'll update the patch. -- Stephen J. Kiernan Juniper Networks, Inc. stevek_at_juniper.net