From owner-freebsd-geom@FreeBSD.ORG Thu Aug 19 00:10:05 2010 Return-Path: Delivered-To: freebsd-geom@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E91FF1065694 for ; Thu, 19 Aug 2010 00:10:05 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D90338FC13 for ; Thu, 19 Aug 2010 00:10:05 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id o7J0A5Yv030259 for ; Thu, 19 Aug 2010 00:10:05 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id o7J0A5EL030258; Thu, 19 Aug 2010 00:10:05 GMT (envelope-from gnats) Date: Thu, 19 Aug 2010 00:10:05 GMT Message-Id: <201008190010.o7J0A5EL030258@freefall.freebsd.org> To: freebsd-geom@FreeBSD.org From: jhell Cc: Subject: Re: kern/149762: volume labels with rogue characters X-BeenThere: freebsd-geom@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: jhell List-Id: GEOM-specific discussions and implementations List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Aug 2010 00:10:06 -0000 The following reply was made to PR kern/149762; it has been noted by GNATS. From: jhell To: bug-followup@FreeBSD.org Cc: walter@pelissero.de Subject: Re: kern/149762: volume labels with rogue characters Date: Wed, 18 Aug 2010 20:04:40 -0400 This is a hack, something that you would commonly find in Linux code and is neither a proper or viable workaround for the naming of labels. Instead, using glabel(8) the admin/user can create a local label to FreeBSD that does not change the original nor does it carry over to any other OS that does not understand geom_label's. From the manual page: label Set up a label name for the given provider. This is the ``automatic'' method, where metadata is stored in a provider's last sector. The kernel module geom_label.ko will be loaded if it is not loaded already. Stripping characters no matter what they are with a sysctl is overkill and does not scale well, all the while - presenting false information to the user. I would highly advise against this. If the user does not like the label that appears in msdosfs/{LABEL} then they are free to change that at their own will. I see presenting the label as it is to the user ``important''. Lets not try to prevent a foot shooting but instead document the case in the manual. Also if they are using FreeBSD and they are also adding a mount-point to fstab(5) for a geom_label then intelligence lurks within. Regards, -- jhell,v