From owner-freebsd-acpi@FreeBSD.ORG Wed Jun 20 20:55:58 2012 Return-Path: Delivered-To: freebsd-acpi@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 968C01065673; Wed, 20 Jun 2012 20:55:58 +0000 (UTC) (envelope-from seanbru@yahoo-inc.com) Received: from mrout1-b.corp.bf1.yahoo.com (mrout1-b.corp.bf1.yahoo.com [98.139.253.104]) by mx1.freebsd.org (Postfix) with ESMTP id 554558FC22; Wed, 20 Jun 2012 20:55:58 +0000 (UTC) Received: from [IPv6:::1] (rideseveral.corp.yahoo.com [10.73.160.231]) by mrout1-b.corp.bf1.yahoo.com (8.14.4/8.14.4/y.out) with ESMTP id q5KKsd9M080350; Wed, 20 Jun 2012 13:54:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=yahoo-inc.com; s=cobra; t=1340225681; bh=b1T1z5K/D8ecPO0oi4cDJ9ap9WJtfsavWQZMazpCWw4=; h=Subject:From:To:Cc:In-Reply-To:References:Content-Type:Date: Message-ID:Mime-Version:Content-Transfer-Encoding; b=VZDqwXSBRsWBmOA5Tkh/Un7BkZ7jGWFYG2UU/cxa7uUNvTQIwFSPQ/8tCAFYOHPb1 vWQZJlL31P61XPazPNYVjb2cC9CelMwdBgzIoIownBYdL6uigTwVm4o5PfsK1Q5dmb GkLNbRouoJTCE4JtAdxasFqKTbg2SatEhKo5oeP4= From: Sean Bruno To: Andriy Gapon In-Reply-To: <4FE23004.3080609@FreeBSD.org> References: <1340121728.5203.8.camel@powernoodle> <4FE0EA24.6000906@FreeBSD.org> <1340142162.3201.12.camel@powernoodle.corp.yahoo.com> <4FE158FF.5070209@FreeBSD.org> <1340208849.2858.2.camel@powernoodle.corp.yahoo.com> <4FE23004.3080609@FreeBSD.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 20 Jun 2012 13:54:39 -0700 Message-ID: <1340225679.2858.26.camel@powernoodle.corp.yahoo.com> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit X-Milter-Version: master.31+4-gbc07cd5+ X-CLX-ID: 225680001 Cc: "sbruno@freebsd.org" , "freebsd-acpi@freebsd.org" Subject: Re: [CFT] Sparse Cstate Support -- Its possible, that I don't know what I'm doing. X-BeenThere: freebsd-acpi@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: ACPI and power management development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Jun 2012 20:55:58 -0000 On Wed, 2012-06-20 at 13:18 -0700, Andriy Gapon wrote: > > I also, disagree with the idea of "FreeBSD C-states" as that is not > the > > intention of the code. The code, from my read, is trying to > interpret > > C-states as though they are always defined sequentially and > non-sparse. > > I seem to recall that this is an ACPI requirement. I could be > mistaken, but no > time to double-check at the moment. > > Just to check as I'm actively looking at this code I went and grabbed the December 6, 2011 ACPI spec. http://www.acpi.info/spec.htm chap 8.1 pretty clearly states that C2 and C3 are optional states. So it appears that you can have a C3 without a C2. So, I suspect that the idea that the index the cx_states array is always going to be 1 less that the ACPI Cstate value isn't by spec. Or something ... :-) Sean "I have no idea how computers work" Bruno