Date: Fri, 29 Aug 2014 13:31:14 -0300 From: William Grzybowski <wg@freebsd.org> To: Antoine Brodin <antoine@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, ports-committers <ports-committers@freebsd.org> Subject: Re: svn commit: r366524 - head/devel/libavl Message-ID: <CAHtVNLMeNSC_TSc-MWC92Y_rm_wn3wCzQKaFOhDx=JDFa_hbEg@mail.gmail.com> In-Reply-To: <201408291613.s7TGD21p034102@svn.freebsd.org> References: <201408291613.s7TGD21p034102@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Fri, Aug 29, 2014 at 1:13 PM, Antoine Brodin <antoine@freebsd.org> wrote: > Author: antoine > Date: Fri Aug 29 16:13:01 2014 > New Revision: 366524 > URL: http://svnweb.freebsd.org/changeset/ports/366524 > QAT: https://qat.redports.org/buildarchive/r366524/ > > Log: > Allow staging as a regular user > > Modified: > head/devel/libavl/Makefile > > Modified: head/devel/libavl/Makefile > ============================================================================== > --- head/devel/libavl/Makefile Fri Aug 29 15:56:59 2014 (r366523) > +++ head/devel/libavl/Makefile Fri Aug 29 16:13:01 2014 (r366524) > @@ -15,4 +15,7 @@ GNU_CONFIGURE= yes > > INFO= avl > > +post-patch: > + ${REINPLACE_CMD} -e '/echo.*RANLIB/,+1d' ${WRKSRC}/Makefile.in > + > .include <bsd.port.mk> Maybe its worth putting a comment in the code about it? Its not direct obvious, at least for me, that a sed in a line containing RANLIB would allow a regular user to stage the port. Maybe its just me being paranoid or w/e, if so disregard :) Thanks, -- William Grzybowski / wg FreeBSD Ports Committer
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAHtVNLMeNSC_TSc-MWC92Y_rm_wn3wCzQKaFOhDx=JDFa_hbEg>