From owner-freebsd-pf@FreeBSD.ORG  Wed Oct 16 07:16:45 2013
Return-Path: <owner-freebsd-pf@FreeBSD.ORG>
Delivered-To: freebsd-pf@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTP id 7C4D7D87;
 Wed, 16 Oct 2013 07:16:45 +0000 (UTC) (envelope-from mm@FreeBSD.org)
Received: from mail.vx.sk (mail.vx.sk [IPv6:2a01:4f8:150:6101::4])
 by mx1.freebsd.org (Postfix) with ESMTP id 3E2E12645;
 Wed, 16 Oct 2013 07:16:45 +0000 (UTC)
Received: from core.vx.sk (localhost [127.0.0.2])
 by mail.vx.sk (Postfix) with ESMTP id 6B0FA4FA75;
 Wed, 16 Oct 2013 09:16:44 +0200 (CEST)
X-Virus-Scanned: amavisd-new at mail.vx.sk
Received: from mail.vx.sk by core.vx.sk (amavisd-new, unix socket) with LMTP
 id 5QtddLw3McJm; Wed, 16 Oct 2013 09:16:44 +0200 (CEST)
Received: from [192.168.2.103] (dslb-092-078-050-209.pools.arcor-ip.net
 [92.78.50.209]) by mail.vx.sk (Postfix) with ESMTPSA id C94854FA6E;
 Wed, 16 Oct 2013 09:16:43 +0200 (CEST)
Message-ID: <525E3D5B.5020903@FreeBSD.org>
Date: Wed, 16 Oct 2013 09:16:43 +0200
From: Martin Matuska <mm@FreeBSD.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:24.0) Gecko/20100101 Thunderbird/24.0
MIME-Version: 1.0
To: Gleb Smirnoff <glebius@FreeBSD.org>, Marco Zec <zec@fer.hr>
Subject: VIMAGE + PF crashes - possible solutions
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Cc: Adrian Chadd <adrian@FreeBSD.org>, freebsd-pf@FreeBSD.org
X-BeenThere: freebsd-pf@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: "Technical discussion and general questions about packet filter
 \(pf\)" <freebsd-pf.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-pf>
List-Post: <mailto:freebsd-pf@freebsd.org>
List-Help: <mailto:freebsd-pf-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-pf>,
 <mailto:freebsd-pf-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 16 Oct 2013 07:16:45 -0000

Hi, I have encountered the same mtag panic Craig had with VIMAGE + PF
and have reported this in a PR 182964:
http://www.freebsd.org/cgi/query-pr.cgi?pr=kern/182964

Here are two possible solutions I would like to discuss, both make the
panic go away:

1.) de-virtualize the variable as Marco suggested, this solution is a
more intrusive change to pf.c
http://people.freebsd.org/~mm/patches/pf_mtag.patch

2.) add vnet context to struct m_tag, this is less intrusive to pf.c and
the uma zone remains virtualized:
http://people.freebsd.org/~mm/patches/pf_mtag.2.patch

Which of the approaches should we take or is this to be solved in a
completely different way?

Anyway, after patching I have fired another panic, this time caused by
missing vnet context in the pf overload task queue.
I have discussed a solution for this one with Gleb and he committed it
in r256587:
http://svnweb.freebsd.org/base?view=revision&revision=256587

With both patches applied my VIMAGE + PF system runs stable.

Thanks,
mm